Package: src:sen Version: 0.8.1-1 Severity: grave Tags: ftbfs patch upstream Control: forwarded -1 https://github.com/TomasTomecek/sen/issues/192 Control: affects -1 + src:urwid
Dear Debian sen package maintainer,
sen 0.8.1-1 fails to build from source and fails its autopkgtest
against python3-urwid 4.1.3-1, which is now in unstable. The test
module tests/test_widgets.py imports SimpleListWalker from the old
module path urwid.listbox:
ImportError while importing test module '.../tests/test_widgets.py'.
Traceback:
tests/test_widgets.py:7: in <module>
from urwid.listbox import SimpleListWalker
E ModuleNotFoundError: No module named 'urwid.listbox'
urwid 3.x still provided urwid.listbox as a deprecated alias for
urwid.widget.listbox, emitting a DeprecationWarning. urwid 4.0.0
removed all of these old-path aliases, so the import now fails.
Since pybuild runs pytest during the build, this is a FTBFS in sid,
and the autopkgtest regression currently blocks urwid 4.1.3-1 from
migrating to Debian Testing.
The installed sen code itself does not use any removed urwid module
path or API; only this one test import is affected.
The fix is a one-line change, already proposed upstream in
https://github.com/TomasTomecek/sen/issues/192. SimpleListWalker is
exported from the urwid top-level namespace in both urwid 3.x and
4.x, so the change is backwards compatible:
--- a/tests/test_widgets.py
+++ b/tests/test_widgets.py
@@ -4,7 +4,7 @@
import pytest
from flexmock import flexmock
-from urwid.listbox import SimpleListWalker
+from urwid import SimpleListWalker
from sen.tui.widgets.list.base import WidgetBase
from sen.tui.widgets.list.common import ScrollableListBox,
AsyncScrollableListBox
I intend to upload a team upload with this fix shortly.
Thanks,
Boyuan Yang
OpenPGP_0xC293E7B461825ACE.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
