Source: python-whey
Version: 0.1.1-6
Severity: important
Tags: patch ftbfs
X-Debbugs-Cc: Bo YU <[email protected]>, Josenilson Ferreira da Silva 
<[email protected]>
Control: affects -1 src:python-editables
Control: tags -1 + fixed-upstream

python-whey's test suite hard-codes the name of the .pth file that
editables generates for editable installs. editables 0.6 renamed it
from <project>.pth to _editable_impl_<project>.pth, so with
python3-editables 0.6 installed the build fails (7 failed, 227 passed,
74 skipped):

  FAILED tests/test_build.py::test_build_editable[0.3-COMPLETE_A]
  FAILED tests/test_build.py::test_build_editable[0.3-COMPLETE_B]
  FAILED tests/test_build.py::test_build_editable[0.3-LONG_REQUIREMENTS]
  FAILED tests/test_build.py::test_build_editable_namespace
  FAILED tests/test_builder_methods.py::test_create_editables_files[0.3]
  FAILED tests/test_pep517_backend.py::test_build_editable[0.3-COMPLETE_A]
  FAILED tests/test_pep517_backend.py::test_build_editable[0.3-COMPLETE_B]

Each one is a FileNotFoundError for whey.pth (default_values.pth in the
namespace test). Because the package uses Testsuite:
autopkgtest-pkg-pybuild, its autopkgtest will fail the same way.

whey itself works fine with 0.6 (it writes _editable_impl_whey.pth);
only the expected file names in the tests are out of date.

python-editables 0.6-1 is ready on Salsa but not uploaded yet:
https://salsa.debian.org/python-team/packages/python-editables
I'm filing this first so it's tracked before that upload. Once 0.6 is
in unstable I'll raise the severity to serious.

Upstream fixed the tests in c29cf907d3 ("Bump editables to 0.6"),
which is not in a release yet:
https://github.com/repo-helper/whey/commit/c29cf907d3ee95080c8f4a60c81a8a584aa0a51b

That commit doesn't apply to 0.1.1, so the attached patch makes the
same change: it renames the expected files and keeps the wheel
contents in the order whey writes them. With it applied, 0.1.1-6
builds in a sid chroot against python3-editables 0.6-1: 234 passed,
74 skipped (the same counts as with 0.5-3 today).

The patched tests only pass with editables 0.6, so the patch can't go
in before the editables upload.


-- System Information:
Debian Release: 13.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 7.1.8+deb13-amd64 (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Description: Update tests for editables 0.6 .pth file name
 editables 0.6 renamed the generated .pth file from <project>.pth to
 _editable_impl_<project>.pth. Update the expected file names in the
 tests and regression fixtures, keeping the order of wheel contents.
 Equivalent to the test changes in upstream commit c29cf907d3.
Author: Mahangu Weerasinghe <[email protected]>
Origin: backport, 
https://github.com/repo-helper/whey/commit/c29cf907d3ee95080c8f4a60c81a8a584aa0a51b
Forwarded: not-needed
Last-Update: 2026-09-24

Index: whey-deb/tests/test_build.py
===================================================================
--- whey-deb.orig/tests/test_build.py
+++ whey-deb/tests/test_build.py
@@ -298,7 +298,7 @@ def test_build_editable(
 
        with handy_archives.ZipFile(tmp_pathplus / wheel) as zip_file:
                data["wheel_content"] = zip_file.namelist()
-               data["pth"] = zip_file.read_text("whey.pth")
+               data["pth"] = zip_file.read_text("_editable_impl_whey.pth")
 
                if sys.version_info >= (3, 7):
                        data["code"] = 
zip_file.read_text("_editable_impl_whey.py").replace(tmp_pathplus.as_posix(), 
"...")
@@ -404,7 +404,7 @@ def test_build_editable_namespace(
 
        with handy_archives.ZipFile(tmp_pathplus / wheel) as zip_file:
                data["wheel_content"] = zip_file.namelist()
-               assert zip_file.read_text("default_values.pth") == 
str(tmp_pathplus) + '\n'
+               assert zip_file.read_text("_editable_impl_default_values.pth") 
== str(tmp_pathplus) + '\n'
 
                
advanced_file_regression.check(zip_file.read_text("default_values-0.5.0.dist-info/METADATA"))
 
Index: whey-deb/tests/test_build_/test_build_editable_0_3_COMPLETE_A_.yml
===================================================================
--- whey-deb.orig/tests/test_build_/test_build_editable_0_3_COMPLETE_A_.yml
+++ whey-deb/tests/test_build_/test_build_editable_0_3_COMPLETE_A_.yml
@@ -13,7 +13,7 @@ stdout: 'Writing whey-2021.0.0.dist-info
 
   Writing whey-2021.0.0.dist-info/entry_points.txt
 
-  Writing whey.pth
+  Writing _editable_impl_whey.pth
 
   Writing _editable_impl_whey.py
 
@@ -31,6 +31,6 @@ wheel_content:
 - whey-2021.0.0.dist-info/METADATA
 - whey-2021.0.0.dist-info/WHEEL
 - whey-2021.0.0.dist-info/entry_points.txt
+- _editable_impl_whey.pth
 - _editable_impl_whey.py
-- whey.pth
 - whey-2021.0.0.dist-info/RECORD
Index: whey-deb/tests/test_build_/test_build_editable_0_3_COMPLETE_B_.yml
===================================================================
--- whey-deb.orig/tests/test_build_/test_build_editable_0_3_COMPLETE_B_.yml
+++ whey-deb/tests/test_build_/test_build_editable_0_3_COMPLETE_B_.yml
@@ -13,7 +13,7 @@ stdout: 'Writing whey-2021.0.0.dist-info
 
   Writing whey-2021.0.0.dist-info/entry_points.txt
 
-  Writing whey.pth
+  Writing _editable_impl_whey.pth
 
   Writing _editable_impl_whey.py
 
@@ -31,6 +31,6 @@ wheel_content:
 - whey-2021.0.0.dist-info/METADATA
 - whey-2021.0.0.dist-info/WHEEL
 - whey-2021.0.0.dist-info/entry_points.txt
+- _editable_impl_whey.pth
 - _editable_impl_whey.py
-- whey.pth
 - whey-2021.0.0.dist-info/RECORD
Index: whey-deb/tests/test_build_/test_build_editable_0_3_LONG_REQUIREMENTS_.yml
===================================================================
--- 
whey-deb.orig/tests/test_build_/test_build_editable_0_3_LONG_REQUIREMENTS_.yml
+++ whey-deb/tests/test_build_/test_build_editable_0_3_LONG_REQUIREMENTS_.yml
@@ -13,7 +13,7 @@ stdout: 'Writing whey-2021.0.0.dist-info
 
   Writing whey-2021.0.0.dist-info/entry_points.txt
 
-  Writing whey.pth
+  Writing _editable_impl_whey.pth
 
   Writing _editable_impl_whey.py
 
@@ -31,6 +31,6 @@ wheel_content:
 - whey-2021.0.0.dist-info/METADATA
 - whey-2021.0.0.dist-info/WHEEL
 - whey-2021.0.0.dist-info/entry_points.txt
+- _editable_impl_whey.pth
 - _editable_impl_whey.py
-- whey.pth
 - whey-2021.0.0.dist-info/RECORD
Index: whey-deb/tests/test_build_/test_build_editable_namespace.yml
===================================================================
--- whey-deb.orig/tests/test_build_/test_build_editable_namespace.yml
+++ whey-deb/tests/test_build_/test_build_editable_namespace.yml
@@ -3,7 +3,7 @@ stdout: 'Writing default_values-0.5.0.di
 
   Writing default_values-0.5.0.dist-info/entry_points.txt
 
-  Writing default_values.pth
+  Writing _editable_impl_default_values.pth
 
   Writing default_values-0.5.0.dist-info/METADATA
 
@@ -19,5 +19,5 @@ wheel_content:
 - default_values-0.5.0.dist-info/METADATA
 - default_values-0.5.0.dist-info/WHEEL
 - default_values-0.5.0.dist-info/entry_points.txt
-- default_values.pth
+- _editable_impl_default_values.pth
 - default_values-0.5.0.dist-info/RECORD
Index: whey-deb/tests/test_builder_methods.py
===================================================================
--- whey-deb.orig/tests/test_builder_methods.py
+++ whey-deb/tests/test_builder_methods.py
@@ -56,7 +56,7 @@ def test_create_editables_files(
                data["stderr"] = outerr.err
 
                data["listdir"] = [p.relative_to(tmpdir).as_posix() for p in 
sort_paths(*tmpdir.iterdir())]
-               data["pth"] = (tmpdir / "whey.pth").read_text()
+               data["pth"] = (tmpdir / "_editable_impl_whey.pth").read_text()
 
                if sys.version_info >= (3, 7):
                        data["code"] = (tmpdir / 
"_editable_impl_whey.py").read_text().replace(tmp_pathplus.as_posix(), "...")
Index: whey-deb/tests/test_builder_methods_/test_create_editables_files_0_3_.yml
===================================================================
--- 
whey-deb.orig/tests/test_builder_methods_/test_create_editables_files_0_3_.yml
+++ whey-deb/tests/test_builder_methods_/test_create_editables_files_0_3_.yml
@@ -6,13 +6,13 @@ code: 'from editables.redirector import
 
   '
 listdir:
+- _editable_impl_whey.pth
 - _editable_impl_whey.py
-- whey.pth
 pth: 'import _editable_impl_whey
 
   '
 stderr: ''
-stdout: 'Writing whey.pth
+stdout: 'Writing _editable_impl_whey.pth
 
   Writing _editable_impl_whey.py
 
Index: whey-deb/tests/test_pep517_backend.py
===================================================================
--- whey-deb.orig/tests/test_pep517_backend.py
+++ whey-deb/tests/test_pep517_backend.py
@@ -312,7 +312,7 @@ def test_build_editable(
 
        with handy_archives.ZipFile(tmp_pathplus / wheel) as zip_file:
                data["wheel_content"] = sorted(zip_file.namelist())
-               data["pth"] = zip_file.read_text("whey.pth")
+               data["pth"] = zip_file.read_text("_editable_impl_whey.pth")
 
                if sys.version_info >= (3, 7):
                        data["code"] = 
zip_file.read_text("_editable_impl_whey.py").replace(tmp_pathplus.as_posix(), 
"...")
Index: 
whey-deb/tests/test_pep517_backend_/test_build_editable_0_3_COMPLETE_A_.yml
===================================================================
--- 
whey-deb.orig/tests/test_pep517_backend_/test_build_editable_0_3_COMPLETE_A_.yml
+++ whey-deb/tests/test_pep517_backend_/test_build_editable_0_3_COMPLETE_A_.yml
@@ -13,7 +13,7 @@ stdout: 'Writing whey-2021.0.0.dist-info
 
   Writing whey-2021.0.0.dist-info/entry_points.txt
 
-  Writing whey.pth
+  Writing _editable_impl_whey.pth
 
   Writing _editable_impl_whey.py
 
@@ -27,10 +27,10 @@ stdout: 'Writing whey-2021.0.0.dist-info
 
   '
 wheel_content:
+- _editable_impl_whey.pth
 - _editable_impl_whey.py
 - whey-2021.0.0.dist-info/LICENSE
 - whey-2021.0.0.dist-info/METADATA
 - whey-2021.0.0.dist-info/RECORD
 - whey-2021.0.0.dist-info/WHEEL
 - whey-2021.0.0.dist-info/entry_points.txt
-- whey.pth
Index: 
whey-deb/tests/test_pep517_backend_/test_build_editable_0_3_COMPLETE_B_.yml
===================================================================
--- 
whey-deb.orig/tests/test_pep517_backend_/test_build_editable_0_3_COMPLETE_B_.yml
+++ whey-deb/tests/test_pep517_backend_/test_build_editable_0_3_COMPLETE_B_.yml
@@ -13,7 +13,7 @@ stdout: 'Writing whey-2021.0.0.dist-info
 
   Writing whey-2021.0.0.dist-info/entry_points.txt
 
-  Writing whey.pth
+  Writing _editable_impl_whey.pth
 
   Writing _editable_impl_whey.py
 
@@ -27,10 +27,10 @@ stdout: 'Writing whey-2021.0.0.dist-info
 
   '
 wheel_content:
+- _editable_impl_whey.pth
 - _editable_impl_whey.py
 - whey-2021.0.0.dist-info/LICENSE
 - whey-2021.0.0.dist-info/METADATA
 - whey-2021.0.0.dist-info/RECORD
 - whey-2021.0.0.dist-info/WHEEL
 - whey-2021.0.0.dist-info/entry_points.txt
-- whey.pth

Reply via email to