The Debian NEW review of python-gymnasium 1.3.0+dfsg+~0.0.6-1 has been completed.
Decision: ACCEPTED Reviewer: Andrew McMillan Review comment: Hi, A couple of minor issues... Copyright attribution is incomplete =================================== - Files: * — Copyright "2024 Farama Foundation" (debian/copyright:9) omits the OpenAI copyright that the shipped LICENSE explicitly lists: "Copyright (c) 2016 OpenAI" and "Copyright (c) 2022 Farama Foundation". Since Gymnasium is a fork of OpenAI Gym, the OpenAI copyright should be preserved. This is an attribution error even if it doesn't affect DFSG compatibility. - Files: dep/* — Copyright "2024 Farama Foundation" (debian/copyright:13) mismatches the actual dep/LICENSE (dep/LICENSE:2), which says "Copyright (c) 2023 Farama Foundation". Packaging quality ================= - Build-time tree mutation in debian/rules:6-7 — cp -r dep/farama_notifications/ . and cp dep/tests/* tests copy files into the source tree during build rather than declaring them via Files-Excluded/setuptools config. It works, but it's fragile (e.g. copying into the upstream tests/ dir could clobber upstream test files if names ever collide) and unusual for a pybuild package. - Bundling without Conflicts/Replaces — debian/control:23-24 declares Provides: python3-farama-notifications (= 0.0.6), which is correct since the module is bundled. But it ships the same files a standalone python3-farama-notifications would, with no Conflicts:/Replaces:; that would collide if such a package ever appears. - Maintainer vs. changelog mismatch — debian/control:3 names Don Xu as Maintainer, but debian/changelog:5 credits the packaging to [email protected] (pkgos-debpypi). The helper role isn't reflected in the control file. These are all quality/accuracy issues, not DFSG blockers — the package is DFSG-free as-is, but the copyright file should be corrected (add OpenAI, fix the dep year) before the next upload. Thanks! Full review details: https://dfsg-new-queue.debian.org/reviews/python-gymnasium
