The Debian NEW review of dart-sass 1.105.0-1 has been completed. Decision: ACCEPTED Reviewer: Andrew McMillan
Review comment: Hi, I have accepted this, but I notice there are a raft of dart packages awaiting review, and I would recommend at least addressing #2 below for other builds. There are attribution-accuracy problems in debian/copyright: 1. Missing third-party attribution (PostCSS). pkg/sass-parser/lib/src/stringifier.ts:7-10 explicitly states "Portions of this source file are adapted from the PostCSS codebase," © 2013 Andrey Sitnik (MIT). The Files: * stanza credits only "2016, Google Inc." and has no separate stanza for these PostCSS-derived portions. Still MIT (DFSG-free), but the copyright file fails to acknowledge a real third-party copyright holder. 2. Files: debian/* stanza absent. The packaging files' own copyright (packager) isn't attributed separately; the lone Files: * stanza technically covers them too but general practice is to include a debian/* stanza recognizing the work of the Debian packagers. Packaging quality ================= Build-Depends incomplete relative to pubspec.yaml. The pubspec declares http and typed_data as dependencies, but dart-http and dart-typed_data are missing from Build-Depends (debian/control:5-34). It currently doesn't break the build only because the compiled entry points (bin/sass.dart, lib/src/js.dart) never import package:http (used only in tool/grind/*) or typed_data. This is fragile and inconsistent; conversely dart-cli-pkg, dart-ffi, dart-fixnum are in Build-Depends though only used by dev tooling, not compiled output. Thanks! Full review details: https://dfsg-new-queue.debian.org/reviews/dart-sass
