The Debian NEW review of dart-pub-semver 2.2.1-1 has been completed.

Decision: ACCEPTED
Reviewer: Andrew McMillan

Review comment:

Hi,

The shipped sources import package:collection/collection.dart:

lib/src/version.dart:7
lib/src/version_union.dart:5

Yet debian/control declares no Depends: at all on the binary package. The 
package's stated purpose is to "ship the Dart sources so that other Dart 
packages can depend on it at build time," but those sources won't compile for 
consumers without collection being provided.

This needs a Depends: dart-collection — otherwise the shipped code is 
incomplete for its intended use.


... or possibly it doesn't.  I know that with debhelper 14 some classes of 
Depends are no longer needed, so perhaps this is one such?  It would be good to 
know...

I guess it's also possible you know this perfectly well, but you have to do it 
this way as you pull this all together from the bootstraps :-)

Thanks!

Full review details: https://dfsg-new-queue.debian.org/reviews/dart-pub-semver

Reply via email to