The Debian NEW review of dart-native-synchronization 0.3.1-1 has been completed.
Decision: ACCEPTED
Reviewer: Andrew McMillan
Review comment:
Hi,
These may be issues that you want to work on. No need to reply with details.
1. Incomplete mtime workaround
debian/rules:13 (override_dh_install) only re-stamps directories (find ...
-type d), but the upstream pub.dev tarball records files with epoch-0 mtimes
too. The claimed problem (files dated 1970-01-01) is not actually fixed for the
regular files, so the override is half-applied and doesn't achieve what its own
comment says. It also hardcodes the package dir name instead of $(CURDIR).
2. Missing dependency on the Dart toolchain/ffi
debian/control:12-14 ships a binary package with no Depends:. Yet
pubspec.yaml:9 declares ffi: ^2.1.0 as a runtime dependency. Consuming this
package as a path dependency via pub get would not have ffi resolvable, so the
package is not self-sufficient as shipped. It should at least depend on the
Dart SDK, and ideally the Debian dart-ffi package.
3. Wrong section
debian/control:2 uses Section: libs for a package that ships only build-time
Dart sources; devel would be more appropriate, matching the intent stated in
the Description ("ships the Dart sources ... depend on it at build time").
4. No test integration
test/ contains mailbox_test.dart and primitives_test.dart, but there is no
Testsuite: autopkgtest in debian/control and no debian/tests/. The shipped
tests are never exercised.
5. debian/install:1-2 ships only lib/ and pubspec.yaml into the package dir;
CHANGELOG.md is omitted from the installed tree (README goes only to
/usr/share/doc via debian/docs). Minor completeness gap for a path-package.
Thanks!
Full review details:
https://dfsg-new-queue.debian.org/reviews/dart-native-synchronization
