The Debian NEW review of golang-github-anacrolix-missinggo 2.1.0-8 has been
completed.
Decision: ACCEPTED
Reviewer: Andrew McMillan
Review comment:
Hi,
I hope the following quality issues are worthwhile...
1. Suspicious install entry
debian/golang-github-anacrolix-missinggo-bin-static.install:1 installs usr/bin
usr/lib/missinggo. dh-golang only emits /usr/bin binaries; there is no build
artifact or upstream install target that produces usr/lib/missinggo. This looks
like a stale/incorrect glob that will silently match nothing (or install the
wrong thing).
2. Inconsistent test-skip story
debian/rules:6-7 skips only TestTimerDrain, yet debian/changelog:16-17 claims
to "skip specific tests" closing two bugs (#1146181, #1017544). The skip list
and the referenced bugs don't obviously correspond, and it also coexists
awkwardly with the retained increase_delayed_test_time.patch (a timing
workaround from -7). Worth reconciling.
3. Unnecessary shlibs dependency
debian/control:67 puts ${shlibs:Depends} on the bin-static package, but these
are statically linked Go binaries (with Built-Using for the toolchain). The
libc dependency it injects is generally unwanted.
4. Fragile, large import-path patch
debian/patches/fix-import-path.patch (~9 KB) rewrites dozens of internal
imports to /v2 because upstream's go.mod declares module
github.com/anacrolix/missinggo/v2 while the source still uses unversioned
imports. This works (verified the working tree is fully consistent; the
pre-patch copies remain only under .pc/), but it's a substantial Debian-side
fork of the source that should really be fixed upstream. Also note the patch
only touches cmd/filecache; the other cmd/* binaries don't import missinggo, so
that's correct.
5. Minor
debian/control:28 uses the legacy XS-Go-Import-Path: prefix (modern dh-golang
accepts X-Go-Import-Path). The debian/copyright Source:/Upstream-Name fields
are fine.
Thanks!
Full review details:
https://dfsg-new-queue.debian.org/reviews/golang-github-anacrolix-missinggo
