The Debian NEW review of kdominate 26.08.1-1 has been completed.

Decision: ACCEPTED
Reviewer: Andrew McMillan

Review comment:

Hi,


Some minor issues you should update debian/copyright to resolve

debian/copyright Files: * (lines 13–17) mislabels every file that upstream 
declares CC0-1.0 as GPL-2.0-or-later. Upstream is REUSE-conformant; REUSE.toml 
(and in-file SPDX headers where possible) attributes these files:
 - README.md, icons/*.png, src/graphics.svg (© Eugene Trounev), src/maps/*.map, 
tests/maps/*.map, doc/index.docbook, doc/settings.png, 
src/org.kde.kdominate.desktop, src/org.kde.kdominate.metainfo.xml, 
src/kdominate.qrc, src/prefs.kcfgc, src/Messages.sh, .gitignore, 
.flatpak-manifest.json (.license file), snapcraft.yaml (in-file header: 
SPDX-License-Identifier: CC0-1.0, © 2024–2026 Scarlett Moore) — all CC0-1.0.
 - debian/copyright already contains a License: CC0-1.0 paragraph (line 95, 
referencing /usr/share/common-licenses/CC0-1.0), but no Files: stanza 
references it — it is dangling, which confirms the intended CC0 stanza was 
omitted. Fix: add a Files: stanza covering the CC0 paths (or reference the 
existing paragraph under Files: *) and drop them from the GPL stanza; that also 
restores the correct holders (Eugene Trounev, Scarlett Moore).
 - Files: po/* (lines 20–31) omits holders named in the files. 
po/es/kdominate.po header carries SPDX-FileCopyrightText: 2026 Sofía Priego and 
2026 Eloy Cuadra, and po/ko/kdominate.po carries 2026 Shinjo Park; none are 
listed in the stanza. Fix: add those three.
 - Minor (folded into the above): the man page's SPDX header says Salvo 
Tomaselli [email protected] while Files: debian/* and the AUTHORS line use 
[email protected]; .gitlab-ci.yml/.kde-ci.yml are SPDX-FileCopyrightText: None 
but the stanza claims 2026 Albert Vaca.


Thanks!

Full review details: https://dfsg-new-queue.debian.org/reviews/kdominate

Reply via email to