This is an automated message from the Debian DFSG, Licensing & New
Packages Team.

The Debian NEW review of python-probatio 0.13.0-1 has been completed.

Decision: ACCEPTED
Reviewer: Andrew McMillan

Review comment:

Hi,

All looks good, but it seems that perhaps debian/watch matches GitHub's 
generated 'untagged-<sha>' ref and reports a bogus newest version

Details...

uscan verbose: `Found the following matching files ... 
refs/tags/untagged-458ad327a1092f4e5d23 (458ad327a1092f4e5d23)` and `Newest 
version ... is 458ad327a1092f4e5d23`; download URL 
`.../tarball/refs/tags/untagged-458ad327a1092f4e5d23`. The GitHub template's 
default pattern matches `untagged-<shortsha>` (a ref GitHub creates for a 
release without a git tag) as if it were a version.

- **Problem:** uscan exits 0 and correctly finds every v-prefixed tag (v0.13.0 
included), but it reports the tagless ref as a NEWER version, so a 
maintainer/CI running uscan is told a non-version '458ad327a1092f4e5d23' is the 
latest release (this mirrors a real, newer tagless GitHub release upstream). It 
will keep surfacing the same junk ref on every run.

- **Fix:** Constrain the GitHub template's Matching-Pattern to real semver 
tags, e.g. `Matching-Pattern: (?:[-_]?[Vv]?)([0-9]+\.[0-9]+\.[0-9]+)$`, so 
tagless `untagged-*` refs are ignored; then re-run uscan to confirm the newest 
reported version is v0.13.0 (a newer tagless release exists upstream but is not 
a tag).


Thanks!

Full review details: https://dfsg-new-queue.debian.org/reviews/python-probatio

Reply via email to