This is an automated message from the Debian DFSG, Licensing & New
Packages Team.

The Debian NEW review of libkazv 1.0.0-1 has been completed.

Decision: ACCEPTED
Reviewer: Andrew McMillan

Review comment:

Hi,

Some issues, not enough to block acceptance, but worth you correcting them...

1. [licensing] COPYING is not covered by any Files stanza (no `Files: *` 
catch-all)

 - **Files:** `debian/copyright (stanza list, lines 6-448)`, `COPYING`
 - **Evidence:** `COPYING` (the full AGPL-3 license text, 33.7 kB) is shipped 
in the source tree and is absent from every `Files:` list; there is no `Files: 
*` stanza, so it matches nothing.
 - **Problem:** debian/copyright must describe every file in the source; an 
unmatched file makes the mapping incomplete (lintian would flag 
files-without-copyright-information).
 - **Fix:** Add a catch-all `Files: *` stanza (with the tusooa/the Kazv Project 
AGPL holders) after the specific stanzas, or add `COPYING` to the main AGPL 
stanza list.

2. [licensing] AGPL short names should be `AGPL-3+`, not `AGPL-3`

 - **Files:** `debian/copyright lines 8, 429, 433, 448 (stanzas) and 450-467 
(standalone License)`
 - **Evidence:** e.g. `.gitlab-ci.yml:3` and `src/base/debug.cpp:4` both read 
`SPDX-License-Identifier: AGPL-3.0-or-later`; the embedded License paragraph 
(debian/copyright lines 453-454) itself says 'either version 3 of the License, 
or (at your option) any later version'.
 - **Problem:** Per copyright-format section 7.2, the short name must carry a 
trailing `+` when the grant permits any later version; `AGPL-3` means version 3 
only, so the short name misstates the actual (broader) grant and contradicts 
both the file headers and the embedded license text.
 - **Fix:** Use `AGPL-3+` in every AGPL stanza and in the standalone License 
stanza.

3. [packaging] Quilt patches lack DEP-3 headers

 - **Files:** `debian/patches/dont-install-private-headers.patch`, 
`debian/patches/use-in-tree-vodozemac-bindings.patch`, 
`debian/patches/use-packaged-crates.patch`, 
`debian/patches/report-deb-built-using.patch`
 - **Evidence:** All four patches begin with bare `--- a/...` diffs and carry 
no `Description:`, `Origin:`/`Forwarded:` or `Author:` fields.
 - **Problem:** debian-policy 4.17 and DEP-3 recommend headers so each patch's 
purpose and provenance (forwarded vs.  Debian-specific) is recorded; e.g. 
`dont-install-private-headers.patch` could plausibly be forwarded upstream, 
while the others are Debian-specific.
 - **Fix:** Add DEP-3 headers (at least Description; Forwarded: not-needed for 
the Debian-specific build/rules patches).


Thanks!

Full review details: https://dfsg-new-queue.debian.org/reviews/libkazv

Reply via email to