Control: tags -1 patch
On Wed, 27 May 2026 14:29:13 +0200 Andreas Henriksson <[email protected]>
wrote:
On Thu, May 14, 2026 at 01:31:44AM +0200, Gioele Barabucci wrote:
> Source: radvd
> Version: 1:2.20-1+b1
> Usertags: pidof-without-procps
>
> Dear maintainer(s) of radvd,
[...]
> ```
> path: radvd_1:2.20-1/debian/tests/daemons
> sysctl -w net.ipv6.conf.all.forwarding=1
> /etc/init.d/${DAEMON} restart > /dev/null 2>&1
> if pidof -x $DAEMON > /dev/null; then
> echo "OK"
> else
> ```
[...]
Usually it's not a good idea to directly invoke init scripts, but in
this test-suite it might be ok (I don't know).
However if it is ok to directly invoke the init script, then that should
also be done to check the status. i.e.
```
/etc/init.d/${DAEMON} restart > /dev/null 2>&1
if /etc/init.d/${DAEMON} status > /dev/null 2>&1 ; then
```
That's a good suggestion, also because initscripts are supposed to use
the Debian-wide pidof-like functionality `pidofproc`.
I turned it into a MR:
<https://salsa.debian.org/debian/radvd/-/merge_requests/3>.
Regards,
--
Gioele Barabucci
