Control: tags -1 patch
On Thu, 14 May 2026 01:32:49 +0200 Gioele Barabucci <[email protected]>
wrote:
it appears that stopmotion uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of stopmotion
that use `pidof` at runtime;
* via the `Build-Depends:` field of stopmotion, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of stopmotion, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that stopmotion uses `pidof` due to the following
code snippets:
```
path: stopmotion_0.9.0-2/src/presentation/frontends/qtfrontend/qtfrontend.cpp
"--every 25 $IMAGEFILE &");
prefs->setPreference("importstopdaemon4",
"kill -2 $(pidof dvgrab)");
//
-----------------------------------------------------------------------
path: stopmotion_0.9.0-2/src/presentation/frontends/qtfrontend/qtfrontend.cpp
"vgrabbj -f $IMAGEFILE -d $VIDEODEVICE -b -D 0 -i vga
-L250000");
prefs->setPreference("importstopdaemon1",
"kill $(pidof vgrabbj)");
// Default import option 3
```
So, `pidof` is used in the default command lines used to stop `dvgrab`
and `vgrabbj`.
Given that the packages related to these programs are only recommended,
and not hard dependencies, it makes sense to recommend `procps` as well.
You can find an MR that fixes this issue at
<https://salsa.debian.org/debian/stopmotion/-/merge_requests/1>.
Regards,
--
Gioele Barabucci