<[email protected]> writes: > Licensing accuracy issues > > 1. Wrong LGPL version in debian/copyright — the main issue. > > debian/copyright:12 declares libknet/* and libnozzle/* as LGPL-2.1+ > and references /usr/share/common-licenses/LGPL-2.1 (line 38). But > every source file header says LGPL-2.0+ [...] (Upstream's own > README.licence also says 2.1, so the mismatch likely came from copying > that rather than the per-file headers — but debian/copyright must > reflect the source headers.)
Hi Andrew, Thanks for the NEW review and for cutting me some slack with the license issues. According to https://github.com/kronosnet/kronosnet/issues/505: | it should be LGPL-2.1+ The COPYING.libraries is correct. It was | probably an oversight at the beginning of the project. The header changes are already merged, so this mismatch will be gone with the next upstream release and debian/copyright already has the correct version. > 2. Wireshark dissector mis-declared as GPL. > > libknet/wireshark/packet-kronosnet.{c,h} are LGPL-2.0+ > (packet-kronosnet.c:8). But the glob libknet/* in DEP-5 does not match > subdirectories Why does it not match subdirectories? According to https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#files-field | Both [* and ?] match slashes (/) and leading dots, unlike shell globs. so I don't see why the dissector would fall through to Files: *. > 3. Build files under the libraries declared LGPL but actually GPL. > > libknet/Makefile.am:7, libnozzle/Makefile.am:7 (and generated > Makefile.in) are GPL-2.0+, yet they sit directly in > libknet//libnozzle/ so they match the libknet/*/libnozzle/* globs and > are declared LGPL-2.1+. Wrong. Thanks, I'll fix the license declaration of the Makefiles. > 4. Minor: config.guess/config.sub mis-versioned. > > These are GPL-3+ (with the FSF exception), but the copyright file only > lists them under the catch-all Files: * → GPL-2+. Note the maintainer > did single out build-aux/git-version-gen as GPL-3+ > (debian/copyright:18-21) but missed these two. These provide a special exception allowing distribution under the license of the containing project. But I'll mention them anyway.
