This is an automated message from the Debian DFSG, Licensing & New Packages Team.
The Debian NEW review of rebol 3.22.5-1 has been completed. Decision: ACCEPTED Reviewer: Andrew McMillan Review comment: Hi, > It found 3 blocker, 5 important, 4 minor issues: > > - [blocker] [licensing] src/modules/prebol.reb forbids distributing > modified versions without REBOL Technologies' approval I don't think it forbids distributing modified versions. It says: « Users are allowed to modify this source, but must keep this header intact. Changes to the official version must be approved by REBOL Technologies » I don't think the version modified by Debian would be labelled "official version"? Yeah, I read that the same way. They would *like* to get these changes back for their official version, but "good luck with that" :-) > - [important] [packaging] Architecture: any overclaims: no build target > exists for ppc64el, s390x or armel That is not a problem per se. > - [important] [packaging] Nine third-party libraries are embedded and built > in-tree although Debian ships them, mbedtls included That should indeed be made a work item on salsa. > - [minor] [packaging] No autopkgtest, although rules already runs a smoke > test That test can indeed be made in autopkgtest, as superficial test. For later. > - [minor] [packaging] The stage1 profile cannot work: it names a siskin > binary that is not in the source and rules calls siskin unconditionally Yes, there is chicken-and-egg with the siskin package, also uploaded at the same time. We'll handle the bootstrap. > - [minor] [packaging] rebol-src (Architecture: all) ships files generated > by the build, and its "build tools" are not in it The build-tool is siskin, which is the one that needs rebol-src to build :) > Whether the generated headers copied into rebol-src differ between > architectures They don't, it's just the source code, for siskin to be able to build. > Whether siskin builds the %rebol3-bulk-linux-arm64 and -riscv64 targets > without further patching Yes, it can. Thanks for your comments - they're very helpful. Full review details: https://dfsg-new-queue.debian.org/reviews/rebol
