On 08/11/26 4:49 am, Subin wrote: > I was triaging through lintian tagged bugs and came across this. I > locally ran lintian (master branch from salsa) on nvidia-graphics-driver > and this false positive is not showing up anymore even though > debian/bug-script still has the following string: > > "<<<<<<<<<< $file >>>>>>>>>>" > > UDD's lintian also doesn't show this false positive anymore: > https://udd.debian.org/lintian/?packages=nvidia-graphics-drivers > > So I believe this bug can be closed.
Thank you so much for trying to help. However, the analysis is wrong. I checked the code in question which has no fix for this since 2021. What "fixed" it was a seemingly incorrect fix for #999756 in https://salsa.debian.org/lintian/lintian/-/commit/2bb5c6a905 which starts to ignore things after `exec`. Sure enough, the bug-script has an "exec >&3" line here https://salsa.debian.org/nvidia-team/nvidia-graphics-drivers/-/blob/550/debian/bug-script?ref_type=heads#L7 And hence the entire thing after that started to be ignored. If I make the following changes and run lintian again I see the issue once again: | $ git --no-pager diff | diff --git a/lib/Lintian/Check/Shell/NonPosix/BashCentric.pm b/lib/Lintian/Check/Shell/NonPosix/BashCentric.pm | index 024ea6a1f..ac66d68a2 100644 | --- a/lib/Lintian/Check/Shell/NonPosix/BashCentric.pm | +++ b/lib/Lintian/Check/Shell/NonPosix/BashCentric.pm | @@ -203,8 +203,8 @@ sub check_bash_centric { | $stashed = $EMPTY; | | # see Bug#999756 and tclsh(1) | - last | - if $line =~ m{^ exec \s }x; | + # last | + # if $line =~ m{^ exec \s }x; | | my $pointer = $item->pointer($position); | | $ bin/lintian /tmp/h/libcuda1_550.163.01-6_amd64.deb --display-info | E: libcuda1: alien-tag binary-file-built-without-LFS-support [usr/share/lintian/overrides/libcuda1:2] | I: libcuda1: bash-term-in-posix-shell '<<<' [usr/share/bug/libcuda1/script:126] | I: libcuda1: bash-term-in-posix-shell '<<<' [usr/share/bug/libcuda1/script:134] There is aflplusplus package for instance which does not have `exec` and output this false-positive diagnostic. https://udd.debian.org/lintian/?email1=&email2=&email3=&packages=aflplusplus&ignpackages=&format=html<_error=on<_warning=on<_information=on&lintian_tag=#all aflplusplus 5.03c-1 (forky sid) afl++/5.03c-1 information bash-term-in-posix-shell 8 '<<<' [usr/bin/afl-whatsup:226] So the bug is still present. Patches to fix that are welcome. As for the false diagnostic of skipping everything after `exec` which is too-simplistic and becomes wrong, I've opened an MR https://salsa.debian.org/lintian/lintian/-/merge_requests/829 to fix that. Thanks again, Nilesh
