Package: release.debian.org
Severity: normal
Tags: trixie
X-Debbugs-Cc: [email protected]
Control: affects -1 + src:fltk1.4
User: [email protected]
Usertags: pu

[ Reason ]
This package addresses a pair of CVEs (jointly reported in
https://bugs.debian.org/1153605) concerning longstanding overflows
that could occur when handling specially crafted BMP and ICO files.

[ Impact ]
Attempting to load specially crafted files in an affected program
could result in crashes or possibly running attacker-supplied code.
AFAICT, fluid is the only program in trixie that attempts to load
user-supplied BMP or ICO files via FLTK 1.4, but user-built or
third-party apps could too.

There are no specific tests, but the changes are small and clearly
correct.

[ Risks ]
Minimal -- each CVE gets a straightforward one-line fix.  The
memory-allocation fix could result in out-of-memory errors, but that
still beats heap corruption.

[ Checklist ]
  [✓] *all* changes are documented in the d/changelog
  [✓] I reviewed all changes and I approve them
  [✓] attach debdiff against the package in (old)stable
  [✓] the issue is verified as fixed in unstable

[ Changes ]
The code now properly rejects files with more than 256 colors, which
are invalid, and takes care to allocate enough memory when dealing
with files with very large dimensions.

[ Other info ]
I initially offered these fixes to the security team, which said they
didn't justify a DSA but could merit inclusion in the next point
release.
diff -Nru fltk1.4-1.4.3/debian/changelog fltk1.4-1.4.3/debian/changelog
--- fltk1.4-1.4.3/debian/changelog      2025-04-29 21:00:37.000000000 -0400
+++ fltk1.4-1.4.3/debian/changelog      2026-11-12 21:13:50.000000000 -0500
@@ -1,3 +1,10 @@
+fltk1.4 (1.4.3-1+deb13u1) trixie; urgency=medium
+
+  * src/Fl_BMP_Image.cxx: Backport upstream buffer and integer overflow
+    fixes (CVE-2026-116723, CVE-2026-116724).  (Closes: #1153605.)
+
+ -- Aaron M. Ucko <[email protected]>  Thu, 12 Nov 2026 21:13:50 -0500
+
 fltk1.4 (1.4.3-1) unstable; urgency=medium
 
   * Final 1.4.3 (and likely 1.4.x) release, with only formal changes
diff -Nru fltk1.4-1.4.3/debian/patches/debian-changes 
fltk1.4-1.4.3/debian/patches/debian-changes
--- fltk1.4-1.4.3/debian/patches/debian-changes 2025-04-29 21:00:37.000000000 
-0400
+++ fltk1.4-1.4.3/debian/patches/debian-changes 2026-11-12 21:13:50.000000000 
-0500
@@ -585,6 +585,29 @@
  
  # Build commands and filename extensions...
  .SUFFIXES:    .0 .1 .3 .6 .c .cxx .mm .h .fl .man .o .z $(EXEEXT)
+--- fltk1.4-1.4.3.orig/src/Fl_BMP_Image.cxx
++++ fltk1.4-1.4.3/src/Fl_BMP_Image.cxx
+@@ -254,6 +254,11 @@ void Fl_BMP_Image::load_bmp_(Fl_Image_Re
+   if (colors_used == 0 && depth <= 8)
+     colors_used = 1 << depth;
+ 
++  if (colors_used > 256) {
++    ld(ERR_FORMAT);
++    return;
++  }
++
+   for (int i = 0; i < colors_used; i++) {
+     // Read BGR color...
+     colormap[i][0] = rdr.read_byte();
+@@ -282,7 +287,7 @@ void Fl_BMP_Image::load_bmp_(Fl_Image_Re
+     ld(ERR_FORMAT);
+     return;
+   }
+-  array = new uchar[width * height * bDepth];
++  array = new uchar[(size_t)width * height * bDepth];
+   alloc_array = 1;
+ 
+   // Read the image data...
 --- fltk1.4-1.4.3.orig/src/Makefile
 +++ fltk1.4-1.4.3/src/Makefile
 @@ -398,6 +398,9 @@ PSCPPFILES = \

Reply via email to