Control: tags 1145454 + patch

Dear maintainer,

I've prepared an NMU for libdeflate (versioned as 1.25-1.1). The diff
is attached to this message.

This NMU backports upstream's tgetopt const-qualifier fix by Ural
Tunaboyu:

https://github.com/ebiggers/libdeflate/commit/cdca9cb86c5846a315375699b1ac4986b4ee3a6d

It applies unchanged.

Before applying this patch, I reproduced that building in pbuilder in
an unstable chroot (gcc 16.2, glibc 2.43-7) fails:

   [Fri Nov 13 20:59:11 UTC 2026] Running libdeflate tests: regular
   [Fri Nov 13 20:59:11 UTC 2026] Running regular_test
   [Fri Nov 13 20:59:11 UTC 2026]     CC=cc CFLAGS="-Werror -
   DLIBDEFLATE_ENABLE_ASSERTIONS" WRAPPER=""
   /build/libdeflate-1.25/programs/tgetopt.c: In function ‘tgetopt’:
   /build/libdeflate-1.25/programs/tgetopt.c:73:36: error:
   initialization discards ‘const’ qualifier from pointer target type
   [-Werror=discarded-qualifiers]
      73 |                         tchar *p = tstrchr(optstring, opt);
         |                                    ^~~~~~~
   cc1: all warnings being treated as errors
   make[4]: ***
   [programs/CMakeFiles/libdeflate_prog_utils.dir/build.make:93:
   programs/CMakeFiles/libdeflate_prog_utils.dir/tgetopt.c.o] Error 1
   
Building 1.25-1.1 passed in the same chroot:

   100% tests passed out of 8
   [Fri Nov 13 21:17:25 UTC 2026] All tests passed!
   
MR submitted so maintainers can merge it to keep the source VCS
matching what is in the archive:

https://salsa.debian.org/deflate-team/libdeflate/-/merge_requests/7

I intend to upload an NMU (with DELAYED/2), but my paperwork to be a
full DD is pending processing so this needs a sponsor.

diffstat for libdeflate-1.25 libdeflate-1.25

 changelog                             |    8 +++++++
 patches/series                        |    1 
 patches/tgetopt-const-qualifier.patch |   37
++++++++++++++++++++++++++++++++++
 3 files changed, 46 insertions(+)

Best regards,

-- 
 _o) Michel Lind
_( ) https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
     README:    https://michel-slm.name/
diff -Nru libdeflate-1.25/debian/changelog libdeflate-1.25/debian/changelog
--- libdeflate-1.25/debian/changelog	2026-05-30 09:17:44.000000000 +0100
+++ libdeflate-1.25/debian/changelog	2026-11-13 21:19:42.000000000 +0000
@@ -1,3 +1,11 @@
+libdeflate (1.25-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Backport upstream's tgetopt const-qualifier fix
+    for FTBFS with glibc 2.43 (Closes: #1145454).
+
+ -- Michel Lind <[email protected]>  Fri, 13 Nov 2026 21:19:42 +0000
+
 libdeflate (1.25-1) unstable; urgency=low
 
   * New upstream version 1.25
diff -Nru libdeflate-1.25/debian/patches/series libdeflate-1.25/debian/patches/series
--- libdeflate-1.25/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ libdeflate-1.25/debian/patches/series	2026-11-13 21:02:56.000000000 +0000
@@ -0,0 +1 @@
+tgetopt-const-qualifier.patch
diff -Nru libdeflate-1.25/debian/patches/tgetopt-const-qualifier.patch libdeflate-1.25/debian/patches/tgetopt-const-qualifier.patch
--- libdeflate-1.25/debian/patches/tgetopt-const-qualifier.patch	1970-01-01 01:00:00.000000000 +0100
+++ libdeflate-1.25/debian/patches/tgetopt-const-qualifier.patch	2026-11-13 21:08:45.000000000 +0000
@@ -0,0 +1,37 @@
+From cdca9cb86c5846a315375699b1ac4986b4ee3a6d Mon Sep 17 00:00:00 2001
+From: Ural Tunaboyu <[email protected]>
+Date: Mon, 2 Mar 2026 12:34:53 -0800
+Subject: [PATCH] tgetopt: use const qualifier from pointer target type
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+Origin: upstream, https://github.com/ebiggers/libdeflate/commit/cdca9cb86c5846a315375699b1ac4986b4ee3a6d
+Bug-Debian: https://bugs.debian.org/1145454
+Applied-Upstream: 1.26
+
+Fixes a build failure against glibc 2.43:
+
+/<<PKGBUILDDIR>>/programs/tgetopt.c: In function ‘tgetopt’:
+/<<PKGBUILDDIR>>/programs/tgetopt.c:73:36: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
+   73 |                         tchar *p = tstrchr(optstring, opt);
+      |                                    ^~~~~~~
+---
+ programs/tgetopt.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/programs/tgetopt.c b/programs/tgetopt.c
+index 868600d..59efcea 100644
+--- a/programs/tgetopt.c
++++ b/programs/tgetopt.c
+@@ -70,7 +70,7 @@ tgetopt(int argc, tchar *argv[], const tchar *optstring)
+ 		} else {
+ 			/* More short options in previous arg */
+ 			tchar opt = *nextchar;
+-			tchar *p = tstrchr(optstring, opt);
++			const tchar *p = tstrchr(optstring, opt);
+ 			if (p == NULL) {
+ 				if (topterr)
+ 					msg("invalid option -- '%"TC"'", opt);
+-- 
+2.53.0
+

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to