Source: freerdp3
Version: 3.33.1+dfsg-1
Severity: normal
Tags: patch

debian/rules passes -DWITH_WINPR_UTILS_IMAGE_JPEG=ON,
-DWITH_WINPR_UTILS_IMAGE_PNG=ON and -DWITH_WINPR_UTILS_IMAGE_WEBP=ON, but
FreeRDP names those options WINPR_UTILS_IMAGE_JPEG, WINPR_UTILS_IMAGE_PNG
and WINPR_UTILS_IMAGE_WEBP (winpr/libwinpr/utils/CMakeLists.txt), all OFF
by default, so the build never turns them on. CMake doesn't warn about the
misspelled names, because the top-level CMakeLists.txt reads every WITH_*
variable when it records the build configuration.

The packages show it. libwinpr3.so.3.33.1 in libwinpr3-3 3.33.1+dfsg-1
links none of libpng, libjpeg and libwebp, and neither does
libwinpr3.so.3.15.0 in trixie's 3.15.0+dfsg-2.1+deb13u3, whose
debian/rules has the same three lines. libpng-dev, libjpeg-dev and
libwebp-dev are already in Build-Depends.

Without these options winpr's clipboard can't convert images to or from
PNG, JPEG or WebP. For example, xfreerdp3 doesn't offer the server an X
selection that holds only image/png or image/jpeg.

Upstream fixed the same names in its own Debian nightly packaging in
commit adf37397b6 ("[cmake] fix preload options").

The patch below renames the three options. Built from upstream 3.33.1
with WINPR_UTILS_IMAGE_PNG=ON and WINPR_UTILS_IMAGE_JPEG=ON,
libwinpr3.so.3.33.1 links libpng16.so.16 and libjpeg.so.62. I haven't
built the Debian package with the patch.

--- a/debian/rules
+++ b/debian/rules
@@ -43,9 +43,9 @@
     -DWITH_SAMPLE=OFF \
     -DWITH_OPENSC_PKCS11_LINKED=OFF \
     -DWITH_VAAPI=OFF \
-    -DWITH_WINPR_UTILS_IMAGE_JPEG=ON \
-    -DWITH_WINPR_UTILS_IMAGE_PNG=ON \
-    -DWITH_WINPR_UTILS_IMAGE_WEBP=ON \
+    -DWINPR_UTILS_IMAGE_JPEG=ON \
+    -DWINPR_UTILS_IMAGE_PNG=ON \
+    -DWINPR_UTILS_IMAGE_WEBP=ON \
     -DWITH_SMARTCARD_EMULATE=ON \
     -DRDTK_FORCE_STATIC_BUILD=ON \
     -DUWAC_FORCE_STATIC_BUILD=ON \

Reply via email to