Package: lintian
Version: 2.144.0
Severity: minor

Hi,

The debian-rules-contains-unnecessary-get-orig-source-target tag is not emitted when the uscan command in the get-orig-source target is prefixed with a make command modifier ("-", "@" or "+").

For example bsh 2.0b4-22 has:

    get-orig-source:
-uscan --download-current-version --force-download --rename --repack

and lintian doesn't report it.

The check in lib/Lintian/Check/Debian/Rules.pm only accepts whitespace before uscan:

    if any { m/^\s+uscan\b/ } @{$rules_per_target{'get-orig-source'}};

Allowing the modifiers would catch these targets:

if any { m/^\s+[-@+]*uscan\b/ } @{$rules_per_target{'get-orig-source'}};


At least 13 source packages have a "-uscan" call in the get-orig-source target: audit, bsh, clirr, fpc, jcifs, jmock, libjgoodies-forms-java, libregexp-java, libstax-java, libxpp3-java, maven, mockobjects and nitime.


Emmanuel Bourg

Reply via email to