Package: ircd-hybrid
Version: 1:8.2.46+dfsg.1-1
Severity: minor
Tags: patch

The package is built with GnuTLS, but the tls_cipher_list
documentation in debian/ircd.conf (inherited from upstream's
reference.conf) only describes the OpenSSL behaviour, and both
commented-out examples use OpenSSL cipher names. With GnuTLS:

- serverinfo {} tls_cipher_list is ignored (libio/src/tls_gnutls.c:
  "TBD: set ciphers based on serverinfo::tls_cipher_list"). Nearby
  options such as tls_supported_groups and tls_cipher_suites already
  say they do nothing with GnuTLS, but this one doesn't.

- connect {} tls_cipher_list is passed to gnutls_priority_init(), so
  it must be a GnuTLS priority string. Uncommenting the shipped
  example makes every outgoing TLS link log:

    Failed to set GnuTLS priorities to 
"ECDHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-SHA:AES256-SHA":
 The request is invalid. Syntax error at position 0, falling back to default 
NORMAL:%SERVER_PRECEDENCE:!VERS-TLS1.1:!VERS-TLS1.0:!VERS-SSL3.0

  The link still comes up using the default, so nothing breaks, but
  an admin who sets this to restrict ciphers gets no restriction at
  all.

Seen on trixie (1:8.2.46+dfsg.1-1); bookworm's 8.2.43 behaves the
same. The patch below only adds documentation. The same text is in
upstream's reference.conf, so it may be worth forwarding the GnuTLS
notes upstream as well.

--- a/debian/ircd.conf
+++ b/debian/ircd.conf
@@ -150,6 +150,9 @@
         *
         * It is recommended to leave this directive commented out and have the
         * TLS library choose the optimal settings.
+        *
+        * This directive currently doesn't do anything with GnuTLS support,
+        * which is what the Debian package is built with.
         */
 #      tls_cipher_list = 
"ECDHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-SHA:AES256-SHA";
 
@@ -612,6 +615,12 @@
 #       *
 #       * It is recommended to leave this directive commented out and have the
 #       * TLS library choose the optimal settings.
+#       *
+#       * Note for Debian users: the package is built with GnuTLS, which takes
+#       * a GnuTLS priority string here (see "Priority strings" in the GnuTLS
+#       * manual), not the OpenSSL cipher list shown below. A string GnuTLS
+#       * can't parse is logged and replaced by the built-in default,
+#       * "NORMAL:%SERVER_PRECEDENCE:!VERS-TLS1.1:!VERS-TLS1.0:!VERS-SSL3.0".
 #       */
 ##     tls_cipher_list = 
"ECDHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-SHA:AES256-SHA";
 #

Reply via email to