Package: kernel-package
Version: 10.049
Followup-For: Bug #377267
I think, the patch is ok.
However, one could use "=" instead of ":=" but
I do not see a difference. However, this could
be a feature, as it allows overriding.
However, I cannot find an issue, where a cleared kernel source
will fail because of the := or the patch at all.
To make sure, I evaluated the issue and tried to find arguments
for that.
Heres my report.
Conclusion: Patch is fine, works as expected. The version.h and the
new include/linux/utsrelease.h is created/updated before accessed
by the scripts.
To find out, I tried to evaluate when the statement in question
will be evaluated by the make-kpkg process:
Using an unpatched kernel-package, a plain 2.6.17-3 (latest debian),
and modifing the misc/version_vars.mk to this statements:
UTS_RELEASE_VERSION=$(shell if [ -f include/linux/version.h ]; then\
echo executed on `date` >>/tmp/check ; sleep 30; grep 'define UTS_RELEASE'
include/linux/version.h |\
perl -nle 'm/^\s*\#define\s+UTS_RELEASE\s+("?)(\S+)\1/g && print $$2;';\
else echo ""; \
fi)
The sleep makes it easier to find excactly the place, where it is
evaluated. I found two places. Both are AFTER the update / evaluation
point of the version.h.
Here is the output-snippet: The place where the script is sleeping is
marked.
I ommit the second access, as it has no influence on the whole thing --
the critical access is the first one, and I proved that this one is
not an issue.
[snip]
make[1]: Leaving directory `/usr/src/linux-source-2.6.17'
/usr/bin/make ARCH=i386 prepare
make[1]: Entering directory `/usr/src/linux-source-2.6.17'
CHK include/linux/version.h
UPD include/linux/version.h
SYMLINK include/asm -> include/asm-i386
SPLIT include/linux/autoconf.h -> include/config/*
CC arch/i386/kernel/asm-offsets.s
GEN include/asm-i386/asm-offsets.h
make[1]: Leaving directory `/usr/src/linux-source-2.6.17'
echo done > debian/stamp-kernel-conf
====== making target CONFIG-indep [new prereqs: conf.vars
stamp-kernel-conf]======
This is kernel package version 10.049.
====== making target CONFIG/linux-source-2.6.17 [new
prereqs: CONFIG-indep]======
====== making target CONFIG/linux-doc-2.6.17 [new prereqs:
CONFIG-indep]======
====== making target CONFIG/linux-manual-2.6.17 [new
prereqs: CONFIG-indep]======
====== making target stamp-configure-indep [new prereqs:
linux-source-2.6.17 linux-doc-2.6.17
linux-manual-2.6.17]======
====== making target configure-indep [new prereqs:
stamp-configure-indep]======
====== making target stamp-configure [new prereqs:
configure-arch configure-indep]======
[snip]
*** here it is, where the script sleep 30 happens. ***
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/dash
Kernel: Linux 2.6.17
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)
Versions of packages kernel-package depends on:
ii dpkg 1.13.22 package maintenance system for Deb
ii dpkg-dev 1.13.22 package building tools for Debian
ii file 4.17-2 Determines file type using "magic"
ii gcc [c-compiler] 4:4.1.1-4 The GNU C compiler
ii gcc-3.2 [c-compiler] 1:3.2.3-9 The GNU C compiler
ii gcc-3.3 [c-compiler] 1:3.3.6-13 The GNU C compiler
ii gcc-4.0 [c-compiler] 4.0.3-4 The GNU C compiler
ii gcc-4.1 [c-compiler] 4.1.1-8 The GNU C compiler
ii gettext 0.14.6-1 GNU Internationalization utilities
ii make 3.81-2 The GNU version of the "make" util
ii perl 5.8.8-6 Larry Wall's Practical Extraction
ii po-debconf 1.0.5 manage translated Debconf template
Versions of packages kernel-package recommends:
ii bzip2 1.0.3-3 high-quality block-sorting file co
ii libc6-dev [libc-dev] 2.3.6-15 GNU C Library: Development Librari
-- no debconf information
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
