On Sat, Jul 29, 2006 at 01:15:27PM +0100, Stephen Gran wrote:
> >
> > Please could you apply the attached patch to disable the checks? (or
> > rewrite
> > the checks in some way that doesn't break relative paths)
>
> Or just use something like:
>
> sub which {
> my $progname = $_ ;
> for my $dir (split /:/, $ENV{"PATH"}) {
> if (-x "$dir/$progname" ) {
> return "$dir/$progname";
> }
> }
> return 0;
> }
>
> And then use constructs like
>
> if (which($postinst_hook)) {
> ...
> }
>
> I can't remember if you use taint mode and warnings and so forth, but if
> you do, substitute an array of known good paths for ENV{"PATH"}.
I think it's better (asides from easier) to just not check that, and let
scripts fail if something is indeed broken in /etc/kernel-img.conf.
Silently skipping broken commands in /etc/kernel-img.conf is not better than
failing and letting the user know about it, IMHO.
> In any event, I am not sure this is RC, but I'll let manoj deal with
> that.
It's release critical only on the basis that, without fixing this, a release
critical bug in another package (#361929) can't be properly addressed.
--
Robert Millan
My spam trap is [EMAIL PROTECTED] Note: this address is only intended for
spam harvesters. Writing to it will get you added to my black list.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
