Hi,
On Thu, 2006-07-20 at 18:00:09 +0100, Ian Jackson wrote:
> Package: dpkg
> Version: 1.3.22
>
> Seen in src/archives.c:
>
> narglist[i++]= strdup("f");
> narglist[i++]= strdup("-print0");
> narglist[i++]= 0;
> execvp(FIND, narglist);
> ohshite(_("failed to exec find for --recursive"));
>
> The same code in dpkg 1.4.0 read:
>
> const char **arglist;
> ...
> arglist[i++]= "f";
> arglist[i++]= "-print0";
> arglist[i++]= 0;
> execvp(FIND, (char* const*)arglist);
>
> and is more correct.
>
> Whoever wrote the patch that introduced these changes was obviously
> insufficiently knowledgeable about C. All contributions by that
> programmer should be reviewed by someone competent.
Then this
<http://cvs.debian.org/dpkg/main/archives.c?root=dpkg&r1=1.24&r2=1.25>
would probably mean reviewing the whole thing...
regards,
guillem
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
