Package: python2.4-moinmoin
Version: 1.5.3-1
Severity: wishlist
Tags: patch
Hi,
please allow - as a valid character in usernames as it's also very
common in email addresses and names.
from user.py, line 133:
username_allowedchars = "'@." # ' for names like O'Brian or email
addresses.
adding a simple - here seems to work fine. A patch is attached.
Thanks,
Bernd
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17.7-grsec
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages python2.4-moinmoin depends on:
ii moinmoin-common 1.5.3-1 Python clone of WikiWiki - common
ii python2.4 2.4.3-8 An interactive high-level object-o
Versions of packages python2.4-moinmoin recommends:
ii postfix [mail-transport-agent 2.2.10-2 A high-performance mail transport
-- no debconf information
diff -Ncr moin-1.5.3.old/MoinMoin/user.py moin-1.5.3/MoinMoin/user.py
*** moin-1.5.3.old/MoinMoin/user.py 2006-08-20 18:55:38.368508240 +0200
--- moin-1.5.3/MoinMoin/user.py 2006-08-20 18:56:10.647601072 +0200
***************
*** 130,136 ****
@return: user name that can be used in acl lines
"""
name = name.replace('_', ' ') # we treat _ as a blank
! username_allowedchars = "'@." # ' for names like O'Brian or email
addresses.
# "," and ":" must not be allowed (ACL
delimiters).
# Strip non alpha numeric characters (except username_allowedchars), keep
white space
name = ''.join([c for c in name if c.isalnum() or c.isspace() or c in
username_allowedchars])
--- 130,136 ----
@return: user name that can be used in acl lines
"""
name = name.replace('_', ' ') # we treat _ as a blank
! username_allowedchars = "'@.-" # ' for names like O'Brian or email
addresses.
# "," and ":" must not be allowed (ACL
delimiters).
# Strip non alpha numeric characters (except username_allowedchars), keep
white space
name = ''.join([c for c in name if c.isalnum() or c.isspace() or c in
username_allowedchars])
