Thanks, I'll take a look. Under the current version, it shows the filename
if there are no tags, but otherwise it shows the tags. I might just consider
 changing it to show the filename along with the tags as a simpler solution;
or perhaps allowing the user to customize the presentation, but I will also
consider your patch.

gregor herrmann wrote:
> Package: randomplay
> Version: 0.52
> Severity: wishlist
> Tags: patch
> 
> Hi Adam,
> 
> one feature I'd like to see in randomplay is the option to show the
> filename of the current song (particularly because I sometimes need
> to fix MP3 tags).
> 
> Find attached a patch that tries to implement this option. 
> 
> Please consider integrating this feature in one of the future
> releases of randomplay.
> 
> Thanks,
> gregor
> 
> -- System Information:
> Debian Release: testing/unstable
>   APT prefers unstable
>   APT policy: (990, 'unstable'), (500, 'experimental'), (500, 'testing'), 
> (500, 'stable')
> Architecture: i386 (i686)
> Shell:  /bin/sh linked to /bin/bash
> Kernel: Linux 2.6.17.200608272304
> Locale: LANG=C, [EMAIL PROTECTED] (charmap=ISO-8859-15)
> 
> Versions of packages randomplay depends on:
> ii  libdate-calc-perl             5.4-4      Perl library for accessing dates
> ii  libmp3-info-perl              1.20-1     Perl MP3::Info - Manipulate / 
> fetc
> ii  libogg-vorbis-header-perl     0.03-1     perl interface to Ogg Vorbis 
> infor
> ii  libterm-readkey-perl          2.30-3     A perl module for simple 
> terminal 
> ii  perl                          5.8.8-6.1  Larry Wall's Practical 
> Extraction 
> 
> Versions of packages randomplay recommends:
> ii  mpg321                        0.2.10.3   A Free command-line mp3 player, 
> co
> ii  vorbis-tools                  1.1.1-6    several Ogg Vorbis tools
> 
> -- no debconf information
> 

------------------------------------------------------------------------

--- randomplay.orig     2006-09-01 14:37:51.000000000 +0200
+++ randomplay  2006-09-01 14:43:21.000000000 +0200
@@ -46,2 +46,3 @@
 my $useutf8 = 1;
+my $showfilename = 0;
 my $maxsize = 0;
@@ -140,2 +141,4 @@
       /^\s*noutf8/i || /^\s*utf8[\s=]*(no|off|false)$/i and $useutf8 = 0;
+      /^\s*filename/i and $showfilename = 1;
+      /^\s*nofilename/i || /^\s*filename[\s=]*(no|off|false)$/i and
$showfilename = 0;
       /^\s*weight/i and $weight_favorites = 1;
@@ -169,2 +172,3 @@
             'utf8!' => \$useutf8,
+            'filename!' => \$showfilename,
             'last=i' => \$last_played,
@@ -410,2 +414,3 @@
     $song_info .= "Weight: " . ($favorite{$next_song} ?
$favorite{$next_song} : 0)  . "\n";
+    $song_info .= "File: ${next_song}\n" if $showfilename;
     print "---------------------\n" . $song_info unless $quiet;
@@ -510,2 +515,4 @@
    --noutf8
+   --filename                        show filename of track (default
nofilename)
+   --nofilename
    -w, --weight                      weight random shuffle to prefer songs
rated as favorites (default weight)



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to