Package: bittornado
Version: 0.3.15-2
Severity: normal
btdownload and btlaunchmany send "event=started" to tracker on startup.
And when quitting, btdownload send "event=stopped" to tracker,
but btlaunchmany does not send "event=stopped" to tracker.
I have found this problem using Wireshark, network traffic analyzer.
I have traced the source of BitTornado.
bittornado-0.3.15/debian/patches/09_timtuckerfixes.dpatch seems to have a bug.
"shutdown" method is never called by wrong indent.
This is a code that 09_timtuckerfixes.dpatch added to launchmanycore.py:
def start(self):
try:
self.handler.listen_forever()
except:
data = StringIO()
print_exc(file=data)
self.Output.exception(data.getvalue())
self.hashcheck_queue = []
for hash in self.torrent_list:
self.Output.message('dropped
"'+self.torrent_cache[hash]['path']+'"')
self.downloads[hash].shutdown() <== shutdown method is called
at here. but
this place is inside of "except" block, so this called when exception.
self.rawserver.shutdown()
I think above code should be write as:
def start(self):
try:
self.handler.listen_forever()
except:
data = StringIO()
print_exc(file=data)
self.Output.exception(data.getvalue())
self.hashcheck_queue = []
for hash in self.torrent_list:
self.Output.message('dropped
"'+self.torrent_cache[hash]['path']+'"')
self.downloads[hash].shutdown()
self.rawserver.shutdown()
The patch 09_timtuckerfixes.dpatch need to be fix.
regards,
Morita Sho
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-2-k7
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)
Versions of packages bittornado depends on:
ii python 2.4.3-11 An interactive high-level object-o
ii python-support 0.5.1 automated rebuilding support for p
Versions of packages bittornado recommends:
ii mime-support 3.37-1 MIME files 'mime.types' & 'mailcap
-- no debconf information
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
