Eduard Bloch wrote:
#include <hallo.h>
* Eugen Dedu [Thu, Sep 21 2006, 06:00:13PM]:
Eduard Bloch wrote:
#include <hallo.h>
* Eugen Dedu [Thu, Sep 21 2006, 01:01:47PM]:
Hi,
Also, I think it is better to have only one executable instead of two:
cdda2ogg and cdda2mp3, the other being a simbolic link. There are only
3 or 4 lines different, I can send you a patch if you agree.
Patch is welcome and consolidation makes sense. I even though about
doing that myself but was too lazy ATM.
Here is cdda2ogg. cdda2mp3 should be a link to cdda2ogg. Do you agree
with the patch?
Almost. I needed to apply stuff manually because you have not attached
it but apparently pasted into a stupid editor which screwed up the
formating. And it was not based on the current SVN. And it was not
fail-save WRT wrong/missing/uppercased suffix. I rewrote most of it.
Very well.
A few questions (the last ones :o)):
1. Why do you put for example MPEG3 or Mp3 in the 'case' instruction?
If the user modifies the name, the script would not function anyway (or
should it function only if the name changes in cdda2Mp3, but not when
the name changes in cdda2mympeg3?!) The user is not intented to modify
the name. I propose to use only ogg and mp3. If you agree, I think it
is better also to replace -c6- by -c6-9 during suffix initialisation.
2. Does MP_CODER really need to be exported?
3. The line
TRACK=`echo $(($TRACK+1))`
is not necessary.
Regards,
--
Eugen
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
