On Thu, Aug 17, 2006 at 10:12:09AM +0200, Petter Reinholdtsen wrote: > An alternative to providing ext2prepare is to remove tune2fs. If > /sbin/tune2fs isn't available, partman-ext3 will use the code path > calling mkfs.ext3, and thus generate file systems with the > resize_inode option enabled.
The included patch makes partman-ext3 always use mkfs, whether tune2fs exists or not. /* Steinar */ -- Homepage: http://www.sesse.net/
diff -Nru /tmp/dl2KndhQLw/partman-ext3-41/commit.d/format_ext3 /tmp/18KUNlxE9f/partman-ext3-41.1/commit.d/format_ext3 --- /tmp/dl2KndhQLw/partman-ext3-41/commit.d/format_ext3 2006-05-10 22:00:43.000000000 +0200 +++ /tmp/18KUNlxE9f/partman-ext3-41.1/commit.d/format_ext3 2006-09-25 16:03:44.000000000 +0200 @@ -49,17 +49,25 @@ db_subst $template DEVICE $(humandev $(cat device)) status=failed - if [ -x /sbin/tune2fs ] && ! [ -f $id/usage ]; then - name_progress_bar $template - open_dialog CREATE_FILE_SYSTEM $id ext2 - read_line status - close_dialog - sync - if [ "$status" = OK ]; then - log-output -t partman --pass-stdout /sbin/tune2fs -j $device >/dev/null || status=failed - sync - fi - fi + + # + # Commented out for now, as partman can't create resizable filesystems + # and ext2prepare is too buggy to use for etch -- we will always use + # mkfs.ext3 directly in etch, although that doesn't give us a progress bar. + # + + # if [ -x /sbin/tune2fs ] && ! [ -f $id/usage ]; then + # name_progress_bar $template + # open_dialog CREATE_FILE_SYSTEM $id ext2 + # read_line status + # close_dialog + # sync + # if [ "$status" = OK ]; then + # log-output -t partman --pass-stdout /sbin/tune2fs -j $device >/dev/null || status=failed + # sync + # fi + # fi + if [ "$status" != OK ]; then db_progress START 0 3 partman/text/formatting db_progress INFO $template