Package: lsb-base
Version: 3.1-15
Severity: minor

There is a small typo in the log_use_fancy_output() function:

--- init-functions.orig 2006-08-25 10:06:01.000000000 +1000
+++ init-functions      2006-09-26 10:18:33.000000000 +1000
@@ -133,7 +133,7 @@
 log_use_fancy_output () {
     TPUT=/usr/bin/tput
     EXPR=/usr/bin/expr
-    if [ FANCYTTY = 0 ]; then
+    if [ "x$FANCYTTY" = 0 ]; then
         false
     fi
     if [ "x$TERM" != "xdumb" ] && [ -x $TPUT ] && [ -x $EXPR ] && $TPUT hpa 60 
>/dev/null 2>&1 && $TPUT setaf 1 >/dev/null 2>&1; then

You might consider an alternate fix, which avoids re-testing for a
colour tty each time:

--- init-functions.orig 2006-08-25 10:06:01.000000000 +1000
+++ init-functions      2006-09-26 10:27:59.000000000 +1000
@@ -133,16 +133,17 @@
 log_use_fancy_output () {
     TPUT=/usr/bin/tput
     EXPR=/usr/bin/expr
-    if [ FANCYTTY = 0 ]; then
-        false
-    fi
-    if [ "x$TERM" != "xdumb" ] && [ -x $TPUT ] && [ -x $EXPR ] && $TPUT hpa 60 
>/dev/null 2>&1 && $TPUT setaf 1 >/dev/null 2>&1; then
-        FANCYTTY=1
-        true
-    else
-        FANCYTTY=0
-        false
-    fi
+    if [ -z $FANCYTTY ]; then
+       if [ "x$TERM" != "xdumb" ] && [ -x $TPUT ] && [ -x $EXPR ] && $TPUT hpa 
60 >/dev/null 2>&1 && $TPUT setaf 1 >/dev/null 2>&1; then
+           FANCYTTY=1
+       else
+           FANCYTTY=0
+       fi
+    fi
+    case "$FANCYTTY" in
+       1|Y|yes|true)   true;;
+       *)              false;;
+    esac
 }
 
 log_success_msg () {


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to