On 10/18/06, Morita Sho <[EMAIL PROTECTED]> wrote:
I can't determine that this comment should be send to bug#387658 that is already
closed. Let me know if you think this comment should be send as new bugreport.

I don't think it's a new bug, as it hasn't yet caused any problems. If
it does cause errors, then a new bug report should be created.

I have installed bittornado 0.3.15-3, and confirmed that bug#387658 is fixed.
I have checked the source code of BitTornado to see what is actually changed to
launchmanycore.py from previous version.

Although "self.rawserver.shutdown()" is placed inside of the try in upstream
code, that is placed outside of the try in Debian's code.

[snip]

I don't know whether it will be a problem or not, but I think it is better to
move "self.rawserver.shutdown()" into the try.
It will be more in line with the original code.

I don't think it matters, as the new function start() is called from
inside the __init__() functions try statement, and so any unhandled
exceptions in the start() function will be passed back to the
__init__() functions except statement. That is my understanding of how
try..except works.

Thanks for the concern, I hope my explanation makes sense.

Cameron


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to