On Tue, 14 Nov 2006 11:11:04 -0500 Mathieu Malaterre wrote: > Francesco Poli wrote: > > On Fri, 10 Nov 2006 18:19:11 -0800 Debian Bug Tracking System wrote: > > > > [...] > >> * Apply fix for two-dimensional PLOT3D by Francesco Poli (Closes: > >> #397186) > > [...] > > > > Thanks for considering and applying my patch! :-) > > An even better solution would have been an upstream patch proposal.
Well, I am a Debian user and I feel that the right place to report bugs I find in Debian packages is the Debian BTS (which is, BTW, the tool I am most familiar with). Anyway, the patch I submitted to Debian is available to anybody interested under the same license as VTK (to the extent it is actually subject to my copyright...): it's *not* that you have to accept some awkward proprietary EULA in order to get it... ;-) Hence, please take a look at my patch: you can adapt it to the latest development version of VTK and incorporate it, if you consider it useful. As I said, to the extent I added enough creative input to actually hold a copyright on it, my patch is available to the general public under the same license as VTK. > Could you please verify the bug report: > > http://vtk.org/Bug/bug.php?op=show&bugid=4041 > > And tell me if this is enough to fix your issue or does this need some > extra work. That bugreport (bugid=4041) seems to address the main issue I detected myself. At least, the first attached patch seems to fix the bug in 2D PLOT3D file loading. But my patch also adds other fixes and enhancements. Once more, please take a look at it yourself... On the other hand, I am not sure about the issue addressed by the second patch that I found attached to bugid=4041: since I haven't had the time to study this second issue, I cannot comment on it. > I would like to avoid this issue creeping back in the next > release of VTK or make the patch out of sync with VTK CVS. I can understand your concerns... -- But it is also tradition that times *must* and always do change, my friend. -- from _Coming to America_ ..................................................... Francesco Poli . GnuPG key fpr == C979 F34B 27CE 5CD8 DC12 31B5 78F4 279B DD6D FCF4
pgpiUDrEWEgVn.pgp
Description: PGP signature
