On Thu, Nov 30, 2006 at 02:33:53PM +0100, Eduard Bloch wrote:
> Hello,
> 
> I tested it again in another environment, and the result ist:
> 
>  - current umount is still segfaulting with UUID labels, without quotes
>    now
>  - with Maxx's patches it does NOT segfault
> 
> but:
> 
>  - with quotes around the UUID, I still get the message about
>    diagreement

Right, and I believe earlier in the bug report it had already been
suggested, "don't put quotes around the UUID".  Without quotes around
the UUID, it works fine --- does that agree with what you are seeing
on your system?

> The last issue should be a separate (minor) bug report, IMO.

I agree that it seems confusing and inconsistent that mount (as root
or a normal user) and unmount (as root) works with double quotes
around the UUID., but umount (as a normal user) does NOT work with
double quotes around the UUID --- even if double quotes are not
supposed to be there.  (And this is already correctly documented in
the fstab(5) man page.)

So therefore, I believe the correct disposition of this patch is:

*) Mark this patch with the tag "patch", and ask LaMont to apply both
   of Max's patches, as they are clearly correct and fix a segfaulting
   issue.  Once it is applied, than this bug can be closed.

*) Open a new minor bug addressing the double-quotes around UUID
   resulting in "umount as user" not working.  Both mount and umount
   should either accept the double quotes, or should give an error
   message indicating an incorrect syntax in /etc/fstab.  I have a
   slight preference towards the first option, since it lessens the
   chances of breaking systems which are working today, but both would
   be correct resolutions to the issue at hand.

Are we all agreed?

                                                - Ted


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to