tag 391528 patch
thanks
On Sat, Oct 07, 2006 at 07:18:52AM +0200, Mike Hommey <[EMAIL PROTECTED]> wrote:
> Package: hal
> Version: 0.5.8.1-1
> Severity: normal
>
> The /usr/lib/hal/linux/hal-system-lcd-set-brightness-linux script is
> broken for the spicctrl method. It uses the same script snippet as the
> -get- script, which is just wrong, while it used to do things correctly.
>
> spicctrl -B should be replaced by spicctrl -b ${value}, and no exit
> value is needed.
Attached is a patch for the issue. Please fix this...
Mike
--- tools/linux/hal-system-lcd-set-brightness-linux.orig 2006-12-07
22:40:45.770124750 +0100
+++ tools/linux/hal-system-lcd-set-brightness-linux 2006-12-07
22:41:28.292782250 +0100
@@ -47,16 +47,7 @@
# http://bugzilla.gnome.org/show_bug.cgi?id=331458
echo "$value" > $HAL_PROP_LINUX_ACPI_PATH
elif [ "$HAL_PROP_LAPTOP_PANEL_ACCESS_METHOD" = "sonypi" ]; then
- # spicctrl -B
- # 70
- # 0..255
- value="`/usr/sbin/spicctrl -B`"
- RETVAL=$?
- if [ $RETVAL != 0 ]; then
- echo "org.freedesktop.Hal.Device.LaptopPanel.NotSupported" >&2
- exit 1;
- fi
- exit ${value}
+ spicctrl -b ${value}
else
echo "org.freedesktop.Hal.Device.LaptopPanel.NotSupported" >&2
echo "No ACPI method found" >&2
