Hello!

On Wed, 06 Dec 2006 20:24:04 +0100, Rasmus Bøg Hansen wrote:
> The attached patch fixes this bug (which I've been bitten by too):

I already posted a similar patch to bug #397088 [1], please let me
comment yours.

> +    if [ ! -d $SCREENDIR ]; then
> +        mkdir $SCREENDIR
> +     chown root:utmp $SCREENDIR
> +     chmod 775 $SCREENDIR

As in my previous patch, why not directly create the directory with
proper permissions and be a bit more verbose?  Thus:
=====
--- /etc/init.d/screen-cleanup  2004-11-14 19:26:30.000000000 +0100
+++ /home/luca/screen-cleanup   2006-12-12 22:02:08.000000000 +0100
@@ -9,6 +9,12 @@
 
 case "$1" in
 start)
+    if [ ! -d $SCREENDIR ]; then
+        echo -n "Creating $SCREENDIR..."
+        mkdir -m 0775 $SCREENDIR
+        chown root:utmp $SCREENDIR
+        echo "done."
+    fi
     if find $SCREENDIR -type p | grep '^' >/dev/null; then
         echo -n 'Cleaning up stale screen sessions... '
         find $SCREENDIR -type p -print0 | xargs -0 rm -f
=====

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=397088

Attachment: pgpu1qriVwljK.pgp
Description: PGP signature

Reply via email to