On Sun, Jan 14, 2007 at 03:55:45AM -0800, Steve Langasek wrote:
> On Sat, Jan 13, 2007 at 09:26:13PM -0800, Thomas Bushnell BSG wrote:
> > Hi Steve; you were very helpful with the last alpha bug reported by this
> > submitter; I'm wondering if you can give it a little attention. I don't
> > have easy access to an alpha to reproduce the problem.
> Please ask upstream where they got the idea that g_type_register_static()
> returned a guint, or that it was otherwise ok to cast its GType return type
> to a guint. Years of debugging crashing gtk+ programs on alpha, and it's
> always the same thing -- somehow, GTK programmers are consistently getting
> bad information about how to use gobject, and I want to know where it's
> coming from so I can lart the people responsible.
> Attached is a partial patch which fixes the bug responsible for the
> *current* crasher bug on alpha. Searching the code, there are several more
> instances of this type abuse that will also need to be cleaned up if we want
> things like searching to not crash. I'll follow up with a full patch soon.
Sigh, now really attached.
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
[EMAIL PROTECTED] http://www.debian.org/
diff -u gnucash-2.0.2/debian/changelog gnucash-2.0.2/debian/changelog
--- gnucash-2.0.2/debian/changelog
+++ gnucash-2.0.2/debian/changelog
@@ -1,3 +1,10 @@
+gnucash (2.0.2-2.2) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * For the 800th time, GType != int. Closes: #406378.
+
+ -- Steve Langasek <[EMAIL PROTECTED]> Sun, 14 Jan 2007 03:40:31 -0800
+
gnucash (2.0.2-2.1) unstable; urgency=medium
* NMU.
only in patch2:
unchanged:
--- gnucash-2.0.2.orig/src/gnome/gnc-split-reg.h
+++ gnucash-2.0.2/src/gnome/gnc-split-reg.h
@@ -159,7 +159,7 @@
/**
* GTK-related; gets an identifier for the class of GNCSplitRegs.
**/
-guint gnc_split_reg_get_type(void);
+GType gnc_split_reg_get_type(void);
/**
* Creates and returns a GNCSplitReg.
only in patch2:
unchanged:
--- gnucash-2.0.2.orig/src/gnome/gnc-split-reg.c
+++ gnucash-2.0.2/src/gnome/gnc-split-reg.c
@@ -170,10 +170,10 @@
FROM_STRING_FUNC(SortType, ENUM_LIST_SORTTYPE)
AS_STRING_FUNC(SortType, ENUM_LIST_SORTTYPE)
-guint
+GType
gnc_split_reg_get_type( void )
{
- static guint gnc_split_reg_type = 0;
+ static GType gnc_split_reg_type = 0;
if (!gnc_split_reg_type)
{
