This one time, at band camp, Marc Haber said: > I can reproduce this bug on sid adduser and have written (and > committed) a test suite case to catch this. > > I would like the people who are more knowledgeable with that part of > the code to comment before I commit this.
The real problem (I think - reflected by the patch I just checked in) is that existing_group_ok is called with an uninitialized $new_gid. This makes existing_group_ok return 1 (that behavior is probably wrong in existing_group_ok, but can be fixed later - for now, we just need to make sure we initialize $new_group before calling it). I have checked in a fix that takes care to initialize $new_group before calling the function, and it looks like it works, although I haven't yet had time to run the test suite on it. -- ----------------------------------------------------------------- | ,''`. Stephen Gran | | : :' : [EMAIL PROTECTED] | | `. `' Debian user, admin, and developer | | `- http://www.debian.org | -----------------------------------------------------------------
signature.asc
Description: Digital signature
