reassign 399483 xemacs21-basesupport 2006.05.10-1
retitle 399483 xemacs21-basesupport: dired-use-ls-dired switch doesn't work
properly
tags 399483 patch
severity 403702 normal
reassign 403702 xemacs21-basesupport 2006.05.10-1
retitle 403702 xemacs21-basesupport: garbage on screen in dired mode
merge 399483 403702
thanks
* Vladimir G. Troitsky <[EMAIL PROTECTED]> [2006-12-18 22:01]:
> Package: xemacs21
> Version: 21.4.19-2
> Severity: minor
>
> There is garbage on the screen in dired mode. Occasionally I get one or
> several copies of the following message in the beginning or the middle
> of a dired fuffer:
>
> //DIRED-OPTIONS// --quoting-style=literal
>
> Also, at the end of the buffer I get a long line like this:
> //DIRED// 62 63 112 114 163 172 221 234 283 289 338 349 398 406 455...
This bug has been already reported as #399483 (hence the merge command
above). Actually, this problem occurs in the xemacs21-basesupport package,
not in xemacs21 (hence the reassign and retitle commands above).
The changes proposed by Peter Chubb in his report seem to work correctly.
Therefore, I took the liberty of producing an appropriate dpatch (attached
below) for the the xemacs21-packages source package (hence the "patch" tag).
Now, the maintainer has no excuse to delaying the fix for the bug ;-)
In waiting for the fixed package, I have added the following code to my
~/.emacs:
(add-hook 'dired-load-hook
(lambda ()
(set-variable 'dired-use-ls-dired
(and (string-match "gnu" system-configuration)
;; Only supported for XEmacs >= 21.5 and GNU Emacs >= 21.4 (I think)
(if (featurep 'xemacs)
(and
(fboundp 'emacs-version>=)
(emacs-version>= 21 5))
(and (boundp 'emacs-major-version)
(boundp 'emacs-minor-version)
(or (> emacs-major-version 21)
(and (= emacs-major-version 21)
(>= emacs-minor-version 4)))))))))
--
Rafael
#! /bin/sh /usr/share/dpatch/dpatch-run
## 02_dired-use-ls-dired.dpatch by Rafael Laboissiere <[EMAIL PROTECTED]>
##
## DP: Fixed logic for the default value of dired-use-ls-dired, which is
## DP: failing in xemacs21. This should fix Bug#399483 and Bug#403702
@DPATCH@
--- xemacs21-packages-2006.05.10.orig/xemacs-packages/dired/dired.el
+++ xemacs21-packages-2006.05.10/xemacs-packages/dired/dired.el
@@ -210,14 +210,15 @@
(defcustom dired-use-ls-dired
(and (string-match "gnu" system-configuration)
;; Only supported for XEmacs >= 21.5 and GNU Emacs >= 21.4 (I think)
- (or (and (featurep 'xemacs)
- (fboundp 'emacs-version>=)
- (emacs-version>= 21 5))
- (and (boundp 'emacs-major-version)
- (boundp 'emacs-minor-version)
- (or (> emacs-major-version 21)
- (and (= emacs-major-version 21)
- (>= emacs-minor-version 4))))))
+ (if (featurep 'xemacs)
+ (and
+ (fboundp 'emacs-version>=)
+ (emacs-version>= 21 5))
+ (and (boundp 'emacs-major-version)
+ (boundp 'emacs-minor-version)
+ (or (> emacs-major-version 21)
+ (and (= emacs-major-version 21)
+ (>= emacs-minor-version 4))))))
"Non-nil means Dired should use `ls --dired'."
:type 'boolean
:group 'dired-programs)
