Bug#411886: bashism in /etc/init.d/monit

[Gian Piero Carrubba]

Package: monit
Version: 1:4.8.1-2.1
Severity: minor
Tags: patch


The '-e' option to echo isn't susv3 ( POSIX ) compliant
[ http://www.opengroup.org/onlinepubs/009695399/utilities/echo.html ].

As you can see below, my /bin/sh is linked to /bin/dash.

$ head -n1 /etc/init.d/monit
#!/bin/sh

$ sudo /etc/init.d/monit start
Starting daemon monitor: -e monit won't be started/stopped
        unless it it's configured
        -e      please configure monit and then edit /etc/default/monit
        -e      and set the "startup" variable to 1 in order to allow
        -e      monit to start

While this is a violation of a 'must' clause of Debian Policy ( §10.4 ),
the impact is almost null, so a minor severity seems more than adequate
to me ( especially during freeze time ).

Please, change the she-bang line to '#!/bin/bash' or apply the attached
patch ( or a similar one ).


Thanks,
Gian Piero.

-- System Information:
Debian Release: 4.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.18-7-king-4
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=UTF-8)

Versions of packages monit depends on:
ii  libc6                       2.3.6.ds1-11 GNU C Library: Shared libraries
ii  libssl0.9.8                 0.9.8c-4     SSL shared libraries

monit recommends no packages.

-- no debconf information

--- /etc/init.d/monit.orig      2006-11-13 13:55:37.000000000 +0100
+++ /etc/init.d/monit   2007-02-21 16:42:44.000000000 +0100
@@ -23,12 +23,12 @@
 ARGS="-d $CHECK_INTERVALS -c $CONFIG -s /var/lib/monit/monit.state"
 
 monit_not_configured () {
-    echo -e "monit won't be started/stopped\n\tunless it it's configured"
+    printf "%b\n" "monit won't be started/stopped\n\tunless it it's configured"
     if [ "$1" != "stop" ]
         then
-        echo -e "\tplease configure monit and then edit /etc/default/monit"
-        echo -e "\tand set the \"startup\" variable to 1 in order to allow "
-        echo -e "\tmonit to start"
+        printf "%b\n" "\tplease configure monit and then edit 
/etc/default/monit"
+        printf "%b\n" "\tand set the \"startup\" variable to 1 in order to 
allow "
+        printf "%b\n" "\tmonit to start"
     fi
     exit 0
 }