On Mon, Mar 12, 2007 at 08:59:15AM -0500, John Goerzen <[EMAIL PROTECTED]> was heard to say: > The first patch, to DownloadQueue.hs, doesn't actually make a difference > to the program execution. getProcessStatus only returns Nothing if it > was run in non-blocking mode and the given pid hadn't exited yet (or it > was given an invalid pid). As it was in the version you patched, that > would never occur. (I have since modified that code to not even deal > with Maybes in the first place). The proper thing to do for curl errors > is to examine the status and see if it was something other than > ExitSuccess.
Oh, ok. I just noticed that while reading the source, and partial functions always set off alarm bells for me. (there are few things more annoying than a program that aborts with the laconic comment "pattern matching failure") I wasn't sure if this was safe, because getProcessStatus's documentation just says that Nothing is returned if the status is "unavailable" without commenting on what makes it available or not. > For the posthook, I think that is a great idea. I wonder, though, if it > would be better to let a person define the hook in the config file > rather than in the database. This would make it easy to set a > post-process hook for all podcasts (they could put it in the [DEFAULT] > section). > > What do you think? I had a lot of stuff written here, but then I re-read it and realized it was incoherent. I'll try again tomorrow. :) Suffice it to say for the moment that I didn't even see that the configuration file had per-podcast sections until you mentioned it. Are the podcast numbers guaranteed not to be reused? Daniel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
