reassign 412986 python-libgmail severity 412986 important tag 412986 + confirmed upstream thanks
Hi libgmail upstream, it seems gmailfs is broken by this "off by 1" change in libgmail.py (from last August, CVS log shown below)... What do you think ? Cheers, --Seb On Wed, Mar 14, 2007 at 07:58:18AM +1100, Richard Jones wrote: > Certainly looks broken. In any case if the ATTACHINFO index really > changed then changing the value of the constant rather than offsetting > it by -1 would have seemed to be the sensible thing to do. It seems > the old value was correct based on the failures we are seeing. > > On 3/14/07, Sebastien Delafond <[EMAIL PROTECTED]> wrote: > >On Wed, Mar 14, 2007 at 12:16:47AM +1100, Richard Jones wrote: > >> Follow up on my last email. I can reproduce the problem by making the > >> change you mention (MI_ATTACHINFO-1). Was there a CVS log message > >> that went along with that change? > > > > ~/work/debian/python-libgmail/cvs/libgmail # cvs diff -r1.86 -r1.87 > > libgmail.py > > Index: libgmail.py > > =================================================================== > > RCS file: /cvsroot/libgmail/libgmail/libgmail.py,v > > retrieving revision 1.86 > > retrieving revision 1.87 > > diff -r1.86 -r1.87 > > 1420c1420 > > < for attachmentInfo in > > msgData[MI_ATTACHINFO]] > > --- > > > for attachmentInfo in > > msgData[MI_ATTACHINFO-1]] > > > >The corresponding log message is: > > > > revision 1.87 > > date: 2006/08/13 14:31:45; author: stas_zytkiewicz; state: Exp; > > lines: +1 -1 > > Fixed bug [ 1539454 ] Off by one error in GmailMessage w/fix > > > >Is this something we want reverted, and should talk to the ligbmail > >upstream about ? > > > >Cheers, > > > >--Seb > > > -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
