This is my suggestion for a new GnuPG.pm. It addresses more than just this 
wish, but separating all the changes into different patches would be messy.

First I don't see why Sign_Release() should open and read the data and 
passphrase into memory. By passing the filenames directly to gpg, like 
Check_Signature() does, forking (to avoid trapping SIGPIPE in case of error, 
I presume) becomes unnecessary. I use open3 to be able to capture the logging 
output so that the full nature of any error can be found in the log, and I 
pass the file descriptor of the tempfile to open3 so that gpg can write to it 
directly.

Other changes: I made gpg_home and gpg_sign_key optional options and I like to 
use a Temp::File object because it automatically unlinks the unless told to 
keep it, which means less to think about when cleaning up after an error.

-- 
Magnus Holmgren        [EMAIL PROTECTED]

Attachment: GnuPG.pm
Description: application/perl-module

Attachment: pgpyILPe52swH.pgp
Description: PGP signature

Reply via email to