On Wed, Mar 30, 2005 at 07:58:22PM -0500, Chris Hanson wrote: > Date: Thu, 31 Mar 2005 01:19:22 +0200 > From: Osamu Aoki <[EMAIL PROTECTED]> > > Package: tpconfig > Version: 3.1.3-5 > Severity: important > Tags: patch l10n > > Hi, I realize this package was not 6 month old but 18 month old. > I saw you uploaded apmd, so I really want you to take attached > consolidated patch and upload this as your fix. > > I'm happy to do the fixes; I've been busy and have had little time > available. But I can make time in the next day or two.
Just apply patch and edit changelog to your name. These diff are trivial for review. These are done deal. > In any case, thank you for your work. > > Do you want to adopt the package? Or to co-maintain it? OK. Can I upload these are new maintainer? > I am not using tpconfig these days as the computer I was using it on > is now very old and rarely turned on, and my newer computer doesn't > have a touchpad. I am using touch pad and annoyed. The only negative is I am not much of code jocky. I will seek co-maintainer from active NM who has some C skill (I mean tracing with GDB. Writing code is high-school thing.). To close all the bugs, we nead feature enhancement. Here is my thought: ================================= tpconfig initialization process Current: * start program * identify port to test (currently fixed to /dev/psaux) * autoprobe alps or synaptic * process command line parameters (starting with '-') separately for alps and synaptic How it should be: * start program and set defaust mousedev = /dev/psaux * read first word of command line argument ($1) * if it is not started with '-', assume it as mousedev and remove from command line (SHIFT-like action to argc argv) * autoprobe alps or synaptic on mousedev * process command line parameters (starting with '-') separately for alps and synaptic This should solve issues. of USB_MOUSE and DEVFS etc. Required tasks): * patch tpconfig.c - Add initial command line handling to set mousedev - Change 3 lines where psaux were used to use mousedev * patch manpage with new synatax tpconfig [/dev/name] [OPTIONS] * Change init script to use MOUSEDEV if available from /etc/default/tpconfig * Add debhelper message to set MOUSEDEV name in /etc/default/tpconfig * Send fix to upstream Check point: Buffer overflow risk manage: limit mousedev to 127 byte? OK? Osamu
signature.asc
Description: Digital signature
