Package: pppconfig
Version: 2.3.10
Severity: minor
> # We better not do anything if a RESOLVBAK already exists.
> ls | grep -q "$RESOLVCONF.bak"
> if [ ! $? ]
> then
> rm -f "$TEMPRESOLV"
> exit 1
> fi
Earlier, you set
RESOLVBAK="$RUNDIR/resolv.conf.bak.$PROVIDER"
which is not the same as "$RESOLVCONF.bak", so the comment doesn't
describe the code fragment accurately.
Also, instead of doing "ls | grep -q" you can do "test -f".
Also, the test that follows only succeeds if "$?" is the null string, which
it never is. (It is a string representing a number.)
-- System Information:
Debian Release: 3.1
APT prefers testing
APT policy: (500, 'testing'), (50, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.10
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)
Versions of packages pppconfig depends on:
ii dialog 1.0-20050306-1 Displays user-friendly dialog boxe
ii ppp 2.4.3-20041231+3 Point-to-Point Protocol (PPP) daem
ii whiptail 0.51.6-20 Displays user-friendly dialog boxe
-- no debconf information
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
