Package: gspca-source
Version: 01.00.12-1
Severity: important

Hi,

building the current gspca-source module on the ARM architecture fails
because a variable name in the code contains the '$' character.

It seems it builds fine on x86, but on ARM the compiler throws errors.

You can test this with a tiny program such as this:

int main(void)
{
  int m$foo = 1;
  return 0;
}

Result on ARM:

a.c: In function 'main':
a.c:3: error: stray '$' in program
a.c:3: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'foo'
a.c:3: error: 'foo' undeclared (first use in this function)
a.c:3: error: (Each undeclared identifier is reported only once
a.c:3: error: for each function it appears in.)


I've tried on ARM (failed) and x86 (worked fine), both times using the
same gcc version:

gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)


Attached patch fixed my build problems on ARM.

I suggest to forward this upstream, too. Dollar signs in variable names
are not such a good idea, IHMO.


HTH, Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
--- gspca_core.c.orig	2007-03-28 12:25:00.000000000 +0200
+++ gspca_core.c	2007-03-28 12:25:18.000000000 +0200
@@ -398,7 +398,7 @@
 	Sonyc002,
 	Vimicro0321,
 	Orbicam,
-	M$VX1000,
+	MSVX1000,
 	Trust610LCDPowerCamZoom,
 	Sonyc001,	
 	LastCamera
@@ -580,7 +580,7 @@
 	{Sonyc002,"Vc0321"},
 	{Vimicro0321,"Vc0321"},
 	{Orbicam,"Logitech Orbicam"},
-	{M$VX1000,"MicroSoft VX1000"},
+	{MSVX1000,"MicroSoft VX1000"},
 	{Trust610LCDPowerCamZoom, "Trust 610 LCD [EMAIL PROTECTED] Zoom"},
 	{Sonyc001,"Sony Visual Communication VGP-VCC1"},
 	{-1, NULL}
@@ -3124,7 +3124,7 @@
 	case 0x045e:
 		switch(product){
 		case 0x00f7:
-			spca50x->desc = M$VX1000;
+			spca50x->desc = MSVX1000;
 			spca50x->bridge = BRIDGE_SN9CXXX;
 			spca50x->sensor = SENSOR_OV7660;
 			spca50x->customid = SN9C105;

Attachment: signature.asc
Description: Digital signature

Reply via email to