Hello,
thank you for your reply to my bug report.
On 05-Apr-01 00:15, Eric Dorland wrote:
> Thanks for the patch, but a few things look funny to me. Especially
> going from a PRUint32 to a long. Can you maybe report this upstream
> (bugzilla.mozilla.org) and see what they have to say?
The problem is that gcc-4.0 does not accept a conversion from a
pointer to a 32 bit intereger type on 64 bit architectures.
The patch which changes 'PRUint32(param)' to 'long(param)' looks
quite innocent to me:
> > diff -urN
> > ../tmp-orig/mozilla-firefox-1.0.1/netwerk/protocol/http/src/nsHttpConnectionMgr.cpp
> > ./netwerk/protocol/http/src/nsHttpConnectionMgr.cpp
> > ---
> > ../tmp-orig/mozilla-firefox-1.0.1/netwerk/protocol/http/src/nsHttpConnectionMgr.cpp
> > 2004-09-02 01:31:03.000000000 +0200
> > +++ ./netwerk/protocol/http/src/nsHttpConnectionMgr.cpp 2005-03-22
> > 13:27:34.000000000 +0100
> > @@ -834,8 +834,8 @@
> > void
> > nsHttpConnectionMgr::OnMsgUpdateParam(nsresult status, void *param)
> > {
> > - PRUint16 name = (PRUint32(param) & 0xFFFF0000) >> 16;
> > - PRUint16 value = PRUint32(param) & 0x0000FFFF;
> > + PRUint16 name = (long(param) & 0xFFFF0000) >> 16;
> > + PRUint16 value = long(param) & 0x0000FFFF;
> >
> > switch (name) {
> > case MAX_CONNECTIONS:
Only the lower 32 bits are used here anyway. I do not see why this
should cause any problems. But I can of course try to discuss this with
upstream.
Regards
Andreas Jochens
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
