Hi Steve. As I've told you in my email before I just tested your patch with the following results (used linux-source-2.6.18 (2.6.18.dfsg.1-12) from testing, of course on an amd64 system):
- The patch applies without problems - The kernel compiles with it without problems (at least with my config) - It boots correctly - and it automatically disables the hardware iommu (look at my dmesg below): Bootdata ok (command line is root=/dev/sda1 ro snd-ice1724.index=0 snd-intel8x0.index=1 ) Linux version 2.6.18debtest (Version:) ([EMAIL PROTECTED]) (gcc version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)) #1 SMP PREEMPT Sat Mar 31 00:42:51 CEST 2007 BIOS-provided physical RAM map: .... .... Normal zone: 387840 pages, LIFO batch:31 Nvidia board detected. Ignoring ACPI timer override. Looks like an nvidia chipset. Disabling HW IOMMU. Override with "iommu=allowed" ACPI: PM-Timer IO Port: 0x8008 .... .... CPU 0: aperture @ ac000000 size 64 MB CPU 1: aperture @ ac000000 size 64 MB PCI-DMA: Using software bounce buffering for IO (SWIOTLB) Placing software IO TLB between 0x1650000 - 0x5650000 Memory: 4036552k/5767168k available (3007k kernel code, 156324k reserved, 1245k data, 216k init) Calibrating delay using timer specific routine.. 4422.28 BogoMIPS (lpj=2211140) Security Framework v1.0.0 initialized .... .... So you see later on the kernel correctly reports to use the swiotlb. I would say (although I'm by any means not kernel expert) that your patch looks good and I _strongly_ recommend to include it in etch r0 (!!)... You're the release manager,... so you should get managed this :-) But I would say that you should add some notes to the release notes. btw: I've CC'ed the mail to Andy so if you don't have time to do this he might... uh and for Andy: have you already signed the etch release key and did you have found some time to sign my personal key I gave you on the last Stammtisch?! Best wishes, Chris.
begin:vcard fn:Mitterer, Christoph Anton n:Mitterer;Christoph Anton email;internet:[EMAIL PROTECTED] x-mozilla-html:TRUE version:2.1 end:vcard