Hello,

thank you for your reply to my bug report.

On 05-Apr-01 22:51, Gaudenz Steinlin wrote:
> Is it just the switch which is no longer supported or is the also an
> actual change in the behaviout of the g++ compiler?

I don't know. 

> Could you please comment some more on your patch. I also see some
> changes to the actual code of passepartout and their implications are
> not clear to me from simply looking at the patch.

The patch addresses the following three different error messages which
occur during the compilation with gcc-4.0:

aboutdialog.cc: In constructor 'AboutDialog::AboutDialog()':
aboutdialog.cc:64: error: '<unnamed>::<anonymous enum>' is/uses anonymous type
aboutdialog.cc:64: error:   trying to instantiate 'template<class A1, class R, 
class C1> SigC::Slot0<R> SigC::bind(const SigC::Slot1<R, C1>&, A1)'
aboutdialog.cc:64: error: no matching function for call to 
'bind(SigC::Slot1<void, int>, <unnamed>::<anonymous enum>)'
aboutdialog.cc:66: error: '<unnamed>::<anonymous enum>' is/uses anonymous type
aboutdialog.cc:66: error:   trying to instantiate 'template<class A1, class R, 
class C1> SigC::Slot0<R> SigC::bind(const SigC::Slot1<R, C1>&, A1)'
aboutdialog.cc:66: error: no matching function for call to 
'bind(SigC::Slot1<void, int>, <unnamed>::<anonymous enum>)'


dialogwrap.cc: In member function 'Gtk::Button* 
DialogWrap::fix_button(Gtk::Button*, int)':
/usr/include/gtkmm-2.0/gtkmm/dialog.h:170: error: 'virtual void 
Gtk::Dialog::on_response(int)' is protected
dialogwrap.cc:26: error: within this context
/usr/include/gtkmm-2.0/gtkmm/dialog.h:170: error: 'virtual void 
Gtk::Dialog::on_response(int)' is protected
dialogwrap.cc:28: error: within this context


../../src/util/valueunit.h: In instantiation of 'ValueUnit<float>':
../../src/util/valueunit.h:61:   instantiated from here
../../src/util/valueunit.h:21: error: template-id 'operator>><>' for 
'std::basic_istream<char, std::char_traits<char> >& 
operator>>(std::basic_istream<char, std::char_traits<char> >&, 
ValueUnit<float>&)' does not match any template declaration
../../src/util/valueunit.h: In function 'std::istream& 
operator>>(std::istream&, ValueUnit<Tp>&) [with Value = float]':
../../src/util/valueunit.h:19: error: 'float ValueUnit<float>::value_' is 
private
../../src/util/valueunit.h:61: error: within this context
../../src/util/valueunit.h:20: error: 'std::basic_string<char, 
std::char_traits<char>, std::allocator<char> > ValueUnit<float>::unit_' is 
private
../../src/util/valueunit.h:68: error: within this context
../../src/util/valueunit.h:20: error: 'std::basic_string<char, 
std::char_traits<char>, std::allocator<char> > ValueUnit<float>::unit_' is 
private
../../src/util/valueunit.h:76: error: within this context


> Also it would be nice if you could create a patch which does not include
> autogenerated files like configure.

The attached patch is much shorter. It just removes '-Wold-style-casts'
from configure.ac and configure and otherwise does not touch those
files.

Regards
Andreas Jochens

diff -urN ../tmp-orig/passepartout-0.6/configure.ac ./configure.ac
--- ../tmp-orig/passepartout-0.6/configure.ac   2004-10-30 17:33:39.000000000 
+0200
+++ ./configure.ac      2005-04-01 23:08:04.258201575 +0200
@@ -10,7 +10,7 @@
 # AC_CONFIG_HEADER(src/defines.h)
 
 # Define global compiler flags:
-MY_CXXFLAGS="-Wall -Wold-style-casts"
+MY_CXXFLAGS="-Wall"
 CXXFLAGS="$CXXFLAGS $MY_CXXFLAGS"
 
 # Checks for programs.
diff -urN ../tmp-orig/passepartout-0.6/configure ./configure
--- ../tmp-orig/passepartout-0.6/configure      2004-10-31 19:54:49.000000000 
+0100
+++ ./configure 2005-04-01 23:08:16.808848393 +0200
@@ -1736,7 +1736,7 @@
 # AC_CONFIG_HEADER(src/defines.h)
 
 # Define global compiler flags:
-MY_CXXFLAGS="-Wall -Wold-style-casts"
+MY_CXXFLAGS="-Wall"
 CXXFLAGS="$CXXFLAGS $MY_CXXFLAGS"
 
 # Checks for programs.
diff -urN ../tmp-orig/passepartout-0.6/src/pptout/aboutdialog.cc 
./src/pptout/aboutdialog.cc
--- ../tmp-orig/passepartout-0.6/src/pptout/aboutdialog.cc      2004-04-26 
19:32:25.000000000 +0200
+++ ./src/pptout/aboutdialog.cc 2005-04-01 23:13:35.372119416 +0200
@@ -16,7 +16,7 @@
 AboutDialog *AboutDialog::_instance = 0;
 
 namespace {
-  enum { OPEN_WEBPAGE = 4711 };
+  enum open_webpage_t { OPEN_WEBPAGE = 4711 };
 }
 
 extern const char *builddate;  
diff -urN ../tmp-orig/passepartout-0.6/src/pptout/widget/dialogwrap.cc 
./src/pptout/widget/dialogwrap.cc
--- ../tmp-orig/passepartout-0.6/src/pptout/widget/dialogwrap.cc        
2004-04-16 16:59:36.000000000 +0200
+++ ./src/pptout/widget/dialogwrap.cc   2005-04-01 23:12:56.154472523 +0200
@@ -23,9 +23,9 @@
   Gtk::Button *b = manage(button);
   // Note: It seems that activate means "in any way except a simple click".
   // So we have to add callbacks for both activate and clicked.
-  b->signal_clicked().connect(bind(slot(*this, &Gtk::Dialog::on_response),
+  b->signal_clicked().connect(bind(slot(*this, &DialogWrap::on_response),
                                   action_id));
-  b->signal_activate().connect(bind(slot(*this, &Gtk::Dialog::on_response),
+  b->signal_activate().connect(bind(slot(*this, &DialogWrap::on_response),
                                    action_id));
   return b;
 }
diff -urN ../tmp-orig/passepartout-0.6/src/util/valueunit.h 
./src/util/valueunit.h
--- ../tmp-orig/passepartout-0.6/src/util/valueunit.h   2004-01-12 
20:01:34.000000000 +0100
+++ ./src/util/valueunit.h      2005-04-01 23:11:05.067300798 +0200
@@ -15,10 +15,8 @@
   const Value& value() const { return value_; }
   const std::string& unit() const { return unit_; }
   
-private:
   Value value_;
   std::string unit_;
-  friend std::istream& operator >> <> (std::istream& in, ValueUnit<Value>& vu);
 };
 
 template <typename Tp>




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to