Bug#420242: [Pkg-xfce-devel] Bug#420242: xfce4-screenshooter-plugin: Creates Screenshot.png on "Cancel"

[Yves-Alexis Perez]

tag #420242 confirmed patch pending
thanks

On ven, 2007-04-20 at 20:36 -0500, Owen Heisler wrote:
> Package: xfce4-screenshooter-plugin
> Version: 1.0.0-2
> Severity: normal
> 
> This version of the screenshot plugin creates a screenshot file even 
> when it is canceled.
> 
> To reproduce:
> 1.Add the plugin to the panel.
> 2.Click the icon to take a screenshot.
> 3.Decide not to take a screenshot: click Cancel.
> 4.~/Screenshot.png is created anyway.
> 

I had already noticed that but never took the time to investigate. If
found a way to fix this, which I've sent for review upstream. Patch is
already waiting in our svn for the next upload.

Regards,
-- 
Yves-Alexis

--- panel-plugin/screenshooter.c.old	2006-04-23 19:12:15.000000000 +0200
+++ panel-plugin/screenshooter.c	2007-04-21 09:03:14.000000000 +0200
@@ -274,6 +274,8 @@
         if (gtk_dialog_run (GTK_DIALOG (sd->chooser)) == GTK_RESPONSE_ACCEPT)
         {    
         filename = gtk_file_chooser_get_filename (GTK_FILE_CHOOSER(sd->chooser));
+        } else {
+          g_free(filename);
         }
         gtk_widget_hide (GTK_WIDGET (sd->chooser));
     }