Package: shell-fm
Version: 0.2+svn20070421.r201-1
Severity: normal
Tags: patch


Shell-fm fails to print bookmarks with non-ascii characters (in UTF8
locale, and only on machines with signed 'char', probably hangs/crashes on
machines with unsigned char).

My bookmarks file contains:

0 = lastfm://artist/Nightwish
1 = lastfm://artist/林原めぐみ/similar
...

shell-fm only prints:
0 = lastfm://artist/Nightwish
1 = lastfm://artist/

with no new line.

Attached patch fixes this bug.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.22-rc3-me (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=uk_UA.UTF-8, LC_CTYPE=uk_UA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages shell-fm depends on:
ii  libao2                       0.8.8-2     Cross Platform Audio Output Librar
ii  libc6                        2.5-9       GNU C Library: Shared libraries
ii  libmad0                      0.15.1b-2.1 MPEG audio decoder library
ii  libncurses5                  5.6-3       Shared libraries for terminal hand
ii  libreadline5                 5.2-3       GNU readline and history libraries

shell-fm recommends no packages.

-- no debconf information
Index: bookmark.c
===================================================================
--- bookmark.c	(revision 212)
+++ bookmark.c	(working copy)
@@ -89,7 +89,7 @@
 
 void printmarks(void) {
 	FILE * fd = fopen(rcpath("bookmarks"), "r");
-	char ch;
+	int ch;
 
 	if(!fd) {
 		puts("No bookmarks.");

Reply via email to