Package: xlog
Version: 1.4-1
Severity: normal
Tags: patch

I typed a lot of remarks into the first and only QSO in a new log and
saved it. It looks like most, if not all, of the remarks saved. The
field goes from 198 to 820 (622 characters.)

The next time I tried to launch xlog, it seemed like nothing happened so
I launched it a few times before trying from the command line to see
'Segmentation fault'

I tracked this down to flog_qso_foreach having a buffer of
FLOG_MAX_LINE_SIZE(300) and reading into it MAX_VARIABLE_LEN(512),
clobbering handle. I don't know the best fix, but for a patch on this
version it worked to have the buffer be MAX_VARIABLE_LEN.

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-k7
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages xlog depends on:
ii libart-2.0-2 2.3.17-1 Library of functions for 2D graphi
ii  libatk1.0-0                1.12.4-3      The ATK accessibility toolkit
ii  libc6                      2.3.6.ds1-13  GNU C Library: Shared libraries
ii libcairo2 1.2.4-4 The Cairo 2D vector graphics libra ii libfontconfig1 2.4.2-1.2 generic font configuration library
ii  libglib2.0-0               2.12.4-2      The GLib library of C routines
ii libgnomeprint2.2-0 2.12.1-7 The GNOME 2.2 print architecture - ii libgtk2.0-0 2.8.20-7 The GTK+ graphical user interface ii libhamlib2 1.2.5-8 Run-time library to control radio ii libpango1.0-0 1.14.8-5 Layout and rendering of internatio
ii  libx11-6                   2:1.0.3-7     X11 client-side library
ii  libxcursor1                1.1.7-4       X cursor management library
ii libxext6 1:1.0.1-2 X11 miscellaneous extension librar ii libxfixes3 1:4.0.1-5 X11 miscellaneous 'fixes' extensio
ii  libxi6                     1:1.0.1-4     X11 Input extension library
ii  libxinerama1               1:1.0.1-4.1   X11 Xinerama extension library
ii  libxml2                    2.6.27.dfsg-1 GNOME XML library
ii  libxrandr2                 2:1.1.0.2-5   X11 RandR extension library
ii libxrender1 1:0.9.1-3 X Rendering Extension client libra ii shared-mime-info 0.19-2 FreeDesktop.org shared MIME databa
ii  zlib1g                     1:1.2.3-13    compression library - runtime

Versions of packages xlog recommends:
ii cwdaemon 0.9.3-1 morse daemon for the parallel or s

-- no debconf information

--
Jacob
diff -cr xlog-1.4/src/logfile/flog.c xlog-1.4.jla/src/logfile/flog.c
*** xlog-1.4/src/logfile/flog.c	Wed Nov 29 09:14:11 2006
--- xlog-1.4.jla/src/logfile/flog.c	Sat Jun  9 19:14:31 2007
***************
*** 194,200 ****
  	FILE *fp = (gpointer) handle->priv;
  	gint i, width, ret;
  	qso_t *q;
! 	gchar buffer[FLOG_MAX_LINE_SIZE];
  
  
  	while (!feof (fp))
--- 194,200 ----
  	FILE *fp = (gpointer) handle->priv;
  	gint i, width, ret;
  	qso_t *q;
! 	gchar buffer[MAX_VARIABLE_LEN];
  
  
  	while (!feof (fp))

Reply via email to